Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0005504 [Squeak] ST80 tweak always 11-24-06 18:14 05-13-14 20:32
Reporter sumi View Status public  
Assigned To nicolas cellier
Priority normal Resolution fixed  
Status resolved   Product Version 3.9
Summary 0005504: [FIX][ENH] editor mode FileList should keeps its contents even if saving as another name
Description We can open a text file using FileList's editor mode, by choosing world menu -> open... -> file... or "do it" a script such as...

(FileStream fileNamed: 'some.txt') edit

Two problems occurs when we change the file's name. Whenever renaming, we have to re-open the renamed file because the code pane, no longer, shows the contents of the text file, but file list of current directory.

The attached changeset file fixes these problems.
Additional Information
Attached Files  FileListLabelTweak.1.cs.gz [^] (1,239 bytes) 11-24-06 18:15
 FileListLabelTweak.2.cs.gz [^] (1,377 bytes) 05-28-08 09:46
 fileEditorSaveAsFix-sumim-M0005504.2.cs [^] (1,551 bytes) 05-07-10 02:47

- Relationships

- Notes
(0010565 - 75 - 75 - 75 - 75 - 75 - 75)
edgardec
04-17-07 11:17

In 3.10 I was able to rename file and the code pane shows the file contents
 
(0012086 - 399 - 453 - 453 - 453 - 453 - 453)
sumi
05-13-08 06:35

Unfortunately, the 3.10 still has the same problem.

Please try a FileList window that is opened by "(FileStream fileNamed: 'some.txt') edit". After rename operation by accept (alt + s) -> "test.txt already exists." pop-up -> select "choose another name" -> input new file name -> accept, you can see that the FileList window shows file list of current directory, not the text previously editing.
 
(0012206 - 365 - 377 - 377 - 377 - 377 - 377)
ScottWallace
05-28-08 09:03

The code in the fileout assumes the presence of an inst var named labelString in FileList, but in most (perhaps all) Squeak versions, FileList does not have an inst var of that name.

Presumably the intention of the fileout is to add the inst var #labelString to FileList, but if so, the class redefinition to accomplish that somehow got omitted from the fileout.
 
(0012207 - 83 - 83 - 83 - 83 - 83 - 83)
sumi
05-28-08 09:52

I attached another change-set file that includes FileList class definition. Thanks.
 
(0013759 - 185 - 209 - 209 - 209 - 209 - 209)
sumi
05-07-10 02:47
edited on: 05-07-10 02:58

This problem still remains in 4.1
So I re-write a new patch that attached as fileEditorSaveAsFix-sumim-M0005504.2.cs
It is replacement of FileListLabelTweak.2.cs we needs no longer.

 
(0014504 - 89 - 95 - 243 - 243 - 243 - 243)
nicolas cellier
05-13-14 20:32

Integrated in trunk (4.6) http://source.squeak.org/trunk/Tools-nice.521.mcz [^]
Thanks sumi!
 

- Issue History
Date Modified Username Field Change
11-24-06 18:14 sumi New Issue
11-24-06 18:15 sumi File Added: FileListLabelTweak.1.cs.gz
04-17-07 11:17 edgardec Note Added: 0010565
05-13-08 06:35 sumi Note Added: 0012086
05-28-08 09:03 ScottWallace Note Added: 0012206
05-28-08 09:46 sumi File Added: FileListLabelTweak.2.cs.gz
05-28-08 09:52 sumi Note Added: 0012207
05-06-10 13:17 sumi Issue Monitored: sumi
05-07-10 02:47 sumi Note Added: 0013759
05-07-10 02:47 sumi File Added: fileEditorSaveAsFix-sumim-M0005504.2.cs
05-07-10 02:58 sumi Note Edited: 0013759
05-13-14 20:32 nicolas cellier Status new => resolved
05-13-14 20:32 nicolas cellier Fixed in Version  => trunk
05-13-14 20:32 nicolas cellier Resolution open => fixed
05-13-14 20:32 nicolas cellier Assigned To  => nicolas cellier
05-13-14 20:32 nicolas cellier Note Added: 0014504


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
69 total queries executed.
43 unique queries executed.
Powered by Mantis Bugtracker