0005566: [Fix][Enh] TestBrowser's open failure/error in TestBrowser opens a new TestBrowser

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0005566

[Squeak] Browser

tweak

always

12-02-06 22:12

12-03-06 04:34

Reporter

jacaetevha

View Status

public

Assigned To

Priority

normal

Resolution

open

Status

new

Product Version

Summary

0005566: [Fix][Enh] TestBrowser's open failure/error in TestBrowser opens a new TestBrowser

Description

I recently selected a failure in one of my test suites while using the
TestBrowser. The context menu offers to browse the test in a system
browser or the test browser. I selected the test browser and to my
surprise a new test browser was opened instead of the one I was in.
So, I patched the "offending" method:

browseFullOnClass: testClass selector: selector browser: browserClass

  browserClass = self class
    ifTrue: [self
      setClass: (self lookupImplementorOfSelector: selector from: testClass)
      selector: selector]
    ifFalse: [browserClass
      fullOnClass: (self lookupImplementorOfSelector: selector from: testClass)
      selector: selector]

Additional Information

Attached Files

Relationships

Notes
(0008530 - 399 - 453 - 453 - 453 - 453 - 453) wiz 12-03-06 04:34	Hi Jason, Thanks for starting the report. It would be good to upload a fileout of the fixed method s.t. others can download and try it easily. It would also be good to have a test for which this is a fix.. Something to check the number of test browsers in the relevant contexts. It should fail in a fresh image until the fix has been installed then it should pass. Cheers - Jerome Peace

Issue History
Date Modified	Username	Field	Change
12-02-06 22:12	jacaetevha	New Issue
12-02-06 22:14	jacaetevha	Summary	TestBrowser's open failure/error in TestBrowser opens a new TestBrowser => [Fix][Enh] TestBrowser's open failure/error in TestBrowser opens a new TestBrowser
12-03-06 04:34	wiz	Note Added: 0008530

Mantis 1.0.8[^]

33 total queries executed.
28 unique queries executed.