| Anonymous | Login | Signup for a new account | 02-09-2010 12:32 UTC |
| Main | My View | View Issues | Change Log | Docs |
| Viewing Issue Simple Details [ Jump to Notes ] | [ View Advanced ] [ Issue History ] [ Print ] | |||||||||||
| ID | Category | Severity | Reproducibility | Date Submitted | Last Update | |||||||
| 0005641 | [Squeak] Tools | minor | always | 12-16-06 13:41 | 01-10-09 01:53 | |||||||
| Reporter | Keith_Hodges | View Status | public | |||||||||
| Assigned To | ||||||||||||
| Priority | normal | Resolution | open | |||||||||
| Status | pending | Product Version | 3.9 | |||||||||
| Summary | 0005641: Cannot override default presentation of Methods in a MethodBrowser | |||||||||||
| Description |
MethodBrowser uses a MessageSet for its method list. The initialization of the MessageSet always creates a new set of MethodReferences with a set 'stringVersion'. This prevents a user supplying a list of MethodReferences with bespoke strings. UseCase: In browsing testCases it would be useful to indicate the testcase class and the class the test method is actually implemented in. MyTestCase>>#testMyTest (inherited from HisTestCase) |
|||||||||||
| Additional Information | ||||||||||||
| Attached Files |
 MethodBrowserImprovements.1.cs [^] (1,718 bytes) 12-16-06 13:43 RecentMessageSet-updateListsAndCodeIn.st [^] (534 bytes) 04-12-07 12:11 RecentChanges.2.cs [^] (3,909 bytes) 04-28-07 11:24 |
|||||||||||
|
|
||||||||||||
 Relationships |
||||||||||||||||
|
||||||||||||||||
|
Notes |
|
|
(0008717 - 426 - 554 - 554 - 554 - 554 - 554) Keith_Hodges 12-16-06 13:47 edited on: 05-03-07 00:00 |
Changed MethodReference before: stringVersion is set anyway. after: stringVersion is left as nil, but stringVersionDefault is used if needed by #asStringOrText Changed MessageSet to use the supplied MethodReferences, setting the stringVersion if none is given. "fix begin" Installer mantis bug: 5641 fix: 'MethodBrowserImprovements.1.cs'. Installer mantis bug: 5641 fix: 'RecentChanges.2.cs'. "fix end" |
|
(0010487 - 88 - 94 - 94 - 94 - 94 - 94) edgardec 04-01-07 14:22 |
This now is 7075MethodBrowserImprovements.cs and was in updates for 3.10 Thanks Keith ! |
|
(0010511 - 134 - 152 - 280 - 280 - 280 - 280) edgardec 04-10-07 09:37 edited on: 04-10-07 09:38 |
Keith , you must see Jerome report at http://bugs.squeak.org/view.php?id=6402. [^] I must revert to previous version of changed methods |
|
(0010622 - 255 - 291 - 291 - 291 - 291 - 291) wiz 04-28-07 20:55 edited on: 04-28-07 20:56 |
Hi Keith, What contexts are your RecentChanges.2.cs supposed to be applied? Please remember that testers other than yourself do not have that context unless you supply it. Is this for 7067 or 7092 or ... or all of the above or none of the above? |
|
(0010623 - 743 - 767 - 767 - 767 - 767 - 767) Keith_Hodges 04-28-07 23:26 |
This bug report at the top of the page says it is for 3.9, so 3.9 it is, thats the context. On the other bug report page, you raised the problem in 3.10. The fact is this is a patch for 3.9, which Edgar kindly applied to 3.10. So if I attempt to improve the patch, I am not responsible for its final integration into 3.10, I still see the context as this bug report which is 3.9 centric because this is actually used in 3.9, so there is no point in producing a 3.10 only patch. RecentChanges.2.cs is for 3.9, if you want to check it out in 3.10, then ignore the irrelevant bits. Sorry but I am tired and fed up. I have removed all of my comments from the other bug report page, because I think that the duplication is counter productive. |
|
(0010880 - 267 - 321 - 321 - 321 - 321 - 321) Damien Cassou 07-15-07 13:49 edited on: 07-15-07 13:50 |
Using the selector browser in a 3.10 7121 image raises an error. This is because #stringVersion is sent in SelectorBrowser>>markMatchingClasses, but it returns nil instead of a string. This makes the tool not as useful as it was. The bug must be corrected. |
|
(0010888 - 161 - 161 - 161 - 161 - 161 - 161) Keith_Hodges 07-17-07 14:14 |
Damien, I thought this has been fixed in my submission recentChanges.2.cs if not then all that has to change is to send #asStringOrText instead of #stringVersion |
|
(0010889 - 64 - 64 - 64 - 64 - 64 - 64) Damien Cassou 07-17-07 14:23 |
RecentChanges.2 corrects the bug. Would be cool to have in 3.10. |
|
(0010890 - 310 - 356 - 356 - 356 - 356 - 356) wiz 07-17-07 16:42 |
The most recent "RecentChanges" seem to be in the parent report. Also as this upgrade has already caused problems once, I highly recommend there be tests to prove it does not still offend. I would not even recommend attempting this fix without the tests. Yours in curiosity and service, --Jerome Peace |
|
(0011192 - 92 - 104 - 232 - 232 - 232 - 232) nicolas cellier 09-24-07 22:28 edited on: 09-24-07 22:29 |
See also http://bugs.squeak.org/view.php?id=6691 [^] which certainly has some duplicated patch |
|
(0011285 - 22 - 22 - 22 - 22 - 22 - 22) Damien Cassou 10-10-07 12:40 |
Reminder sent to: edgardec Don't forget this bug! |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 12-16-06 13:41 | Keith_Hodges | New Issue | |
| 12-16-06 13:43 | Keith_Hodges | File Added: MethodBrowserImprovements.1.cs | |
| 12-16-06 13:47 | Keith_Hodges | Note Added: 0008717 | |
| 12-18-06 10:47 | Keith_Hodges | Note Edited: 0008717 | |
| 01-16-07 14:25 | Keith_Hodges | Note Edited: 0008717 | |
| 04-01-07 14:22 | edgardec | Note Added: 0010487 | |
| 04-10-07 09:37 | edgardec | Note Added: 0010511 | |
| 04-10-07 09:38 | edgardec | Note Edited: 0010511 | |
| 04-12-07 12:11 | Keith_Hodges | File Added: RecentMessageSet-updateListsAndCodeIn.st | |
| 04-12-07 12:12 | Keith_Hodges | Note Edited: 0008717 | |
| 04-12-07 12:13 | Keith_Hodges | Issue Monitored: Keith_Hodges | |
| 04-28-07 11:24 | Keith_Hodges | File Added: RecentChanges.2.cs | |
| 04-28-07 20:55 | wiz | Note Added: 0010622 | |
| 04-28-07 20:56 | wiz | Note Edited: 0010622 | |
| 04-28-07 23:26 | Keith_Hodges | Note Added: 0010623 | |
| 05-03-07 00:00 | Keith_Hodges | Note Edited: 0008717 | |
| 07-15-07 13:49 | Damien Cassou | Note Added: 0010880 | |
| 07-15-07 13:50 | Damien Cassou | Note Edited: 0010880 | |
| 07-15-07 13:50 | Damien Cassou | Issue Monitored: Damien Cassou | |
| 07-17-07 14:14 | Keith_Hodges | Note Added: 0010888 | |
| 07-17-07 14:23 | Damien Cassou | Note Added: 0010889 | |
| 07-17-07 16:39 | wiz | Relationship added | child of 0006402 |
| 07-17-07 16:42 | wiz | Note Added: 0010890 | |
| 09-24-07 22:28 | nicolas cellier | Note Added: 0011192 | |
| 09-24-07 22:29 | nicolas cellier | Note Edited: 0011192 | |
| 09-25-07 05:30 | wiz | Relationship added | child of 0006691 |
| 10-10-07 12:40 | Damien Cassou | Issue Monitored: edgardec | |
| 10-10-07 12:40 | Damien Cassou | Note Added: 0011285 | |
| 07-04-08 01:40 | matthewf | Relationship added | child of 0007110 |
| 07-04-08 01:41 | matthewf | Relationship replaced | related to 0006691 |
| 07-04-08 01:41 | matthewf | Relationship replaced | related to 0006402 |
| 01-10-09 01:53 | Keith_Hodges | Status | new => pending |
| Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
130 total queries executed. 58 unique queries executed. |  |
