Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0005949 [Squeak] Graphics minor always 02-07-07 09:30 02-17-07 10:12
Reporter espin View Status public  
Assigned To andreas
Priority normal Resolution open  
Status assigned   Product Version
Summary 0005949: failing example in comment of Form>>fadeImageCoarse:at: and Form>>fadeImageFine:at:
Description example as in comment at the beginning of
   Form>>fadeImageCoarse:at:
and
   Form>>fadeImageFine:at:
fail.
It is not obvious to me how to make it work.
This happens in 3.7,3.8,3.9 at least.
Additional Information
Attached Files  FadeCoarseFineFix-wiz.3.cs [^] (2,428 bytes) 02-17-07 10:03

- Relationships

- Notes
(0009942 - 418 - 473 - 473 - 621 - 621 - 621)
wiz
02-17-07 08:44

"Change Set: FadeCoarseFineFix-wiz
Date: 17 February 2007
Author: (wiz) Jerome Peace

Fix for mantis 0005949.
These two examples did not work if depth > 8. The problem was that the image and mask blocks were trying to store large intergers into the mask bitmap arrays. the solution was to mask out all the bits that didn't fit."

These are not called anywhere in 3.9 image. Where were they used originally?
 
(0009943 - 91 - 97 - 97 - 97 - 97 - 97)
wiz
02-17-07 08:49

Need to do a little more checking.
The fine fade needs some further tuning and debugging.
 
(0009944 - 858 - 984 - 984 - 984 - 984 - 984)
wiz
02-17-07 10:12

Uploaded FadeCoarseFineFix-wiz.3.cs
Which fixes things so that the transition and don't cause walk backs.

However,

as I looked further into things, I discovered that all the methods with examples in this form catagory were designed to work at depths of 1 !

So their usefulness in present day squeak is questionable.

In short this is vestigial code and should be Removed or at least deprecated.

If something like this is needed then an update to 32 bits is needed.
Hint: The mask will have to be wider and will probably have to be aware of the depth.

Recommendation: Remove the old stuff.
Find out if someone has written an up to date equivalent.
If not find out if one is really needed.
Let the person who needs it make a case for its development.

I am choosing not to persue this any further.

Yours in service, --Jerome Peace
 

- Issue History
Date Modified Username Field Change
02-07-07 09:30 espin New Issue
02-07-07 09:30 espin Status new => assigned
02-07-07 09:30 espin Assigned To  => andreas
02-17-07 08:44 wiz Note Added: 0009942
02-17-07 08:49 wiz Note Added: 0009943
02-17-07 10:03 wiz File Added: FadeCoarseFineFix-wiz.3.cs
02-17-07 10:12 wiz Note Added: 0009944


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
45 total queries executed.
34 unique queries executed.
Powered by Mantis Bugtracker