0006174: Refactoring Browser gives MNU on user error

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0006174

[Squeak] Browser

minor

always

02-19-07 23:36

03-19-08 18:53

Reporter

black

View Status

public

Assigned To

Priority

normal

Resolution

open

Status

new

Product Version

3.9

Summary

0006174: Refactoring Browser gives MNU on user error

Description

If the user mistakenly asks the Refactoring Browser to "inline temporary variable" while the selection is an assignment to an _instance variable_, the refactoring's pre-condition is not met and the user should be given a polite message to that effect.

The user currently gets a MNU walkback!

The attached fixes this problem.

Additional Information

I have included a test, which errors on the current code base, and passes after the fix is installed.

Attached Files

RBInlineTempFix.2.cs [^] (1,437 bytes) 02-19-07 23:36

Relationships

Notes
(0011934 - 264 - 408 - 408 - 408 - 408 - 408) GazzaGuru 03-19-08 18:23	We at Pinesoft have just done a temporary fix for this: BrowserRequestor>>getArgumentPermutation "Answer the argument permutation map. No support for changing argument count." ^(1 to: (self getBrowser selectedMessageName ifNil: [^nil]) numArgs) asArray

(0011936 - 21 - 21 - 21 - 21 - 21 - 21) GazzaGuru 03-19-08 18:53	Sorry, wrong bug #...

Issue History
Date Modified	Username	Field	Change
02-19-07 23:36	black	New Issue
02-19-07 23:36	black	File Added: RBInlineTempFix.2.cs
03-19-08 18:23	GazzaGuru	Note Added: 0011934
03-19-08 18:53	GazzaGuru	Note Added: 0011936

Mantis 1.0.8[^]

38 total queries executed.
29 unique queries executed.