0006337: [FIX] Walkback when Snapshotting classes with uncategorized methods

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0006337

[Squeak] PackageInfo

tweak

always

03-10-07 16:58

03-12-07 19:37

Reporter

matthewf

View Status

public

Assigned To

Priority

normal

Resolution

open

Status

new

Product Version

Summary

0006337: [FIX] Walkback when Snapshotting classes with uncategorized methods

Description

Monticello expects all methods it works with to have a method category, but it PackageInfo gives it all methods, regardless of whether they have a category or not. (by "having a category", I mean that the CompiledMethod is accessible from ClassDescription>>organization.

Uncategorized methods cannot be produced in the browser, so they are not really source code, and therefore should not be snapshotted by Monticello. For instance, ThingLab creates uncategorized methods as part of its MessagePlan for satisfying object constraints; the user never touches them.

The attached changeset modifies PackageInfo>>getCoreMethodsForClass: to disregard uncategorized methods.

Additional Information

Attached Files

PackageInfo-uncategorizedFix.1.cs [^] (557 bytes) 03-10-07 16:58

MCUncategorizedMethodTest.st [^] (863 bytes) 03-11-07 23:57

Relationships

Notes
(0010441 - 263 - 263 - 263 - 263 - 263 - 263) matthewf 03-12-07 00:05	I added a test case that demonstrates the error; the test gives an error without the change, and is green with the change. However, the test does not run on Squeak 3.9 due to an unrelated issue. I wrote it for 3.8, since that is what I am developing ThingLab for.

(0010442 - 57 - 67 - 67 - 67 - 67 - 67) matthewf 03-12-07 07:39	The test has the same "problem" on 3.10 as it does on 3.9

Issue History
Date Modified	Username	Field	Change
03-10-07 16:58	matthewf	New Issue
03-10-07 16:58	matthewf	Status	new => assigned
03-10-07 16:58	matthewf	Assigned To	=> KenCausey
03-10-07 16:58	matthewf	File Added: PackageInfo-uncategorizedFix.1.cs
03-11-07 23:57	matthewf	File Added: MCUncategorizedMethodTest.st
03-12-07 00:05	matthewf	Note Added: 0010441
03-12-07 07:39	matthewf	Note Added: 0010442
03-12-07 19:37	KenCausey	Assigned To	KenCausey =>
03-12-07 19:37	KenCausey	Status	assigned => new
03-12-07 19:37	KenCausey	Category	Any => PackageInfo

Mantis 1.0.8[^]

45 total queries executed.
32 unique queries executed.