Anonymous | Login | 04-12-2021 15:55 UTC |
Main | My View | View Issues | Change Log | Docs |
Viewing Issue Simple Details [ Jump to Notes ] | [ View Advanced ] [ Issue History ] [ Print ] | ||||||||
ID | Category | Severity | Reproducibility | Date Submitted | Last Update | ||||
0006367 | [Squeak] Collections | minor | always | 03-23-07 00:30 | 09-15-09 19:16 | ||||
Reporter | nicolas cellier | View Status | public | ||||||
Assigned To | nicolas cellier | ||||||||
Priority | normal | Resolution | fixed | ||||||
Status | closed | Product Version | |||||||
Summary | 0006367: [BUG] WideString substrings broken | ||||||||
Description |
| w | w := WideString with: 401 asCharacter with: $a with: 402 asCharacter with: $b. self assert: w substrings first = w. |
||||||||
Additional Information |
CharacterSet complement does not take WideCharacter into account... Thus CSNonSeparators String classVar is incomplete... Possible cure: create a CharacterSetComplement class that handles includes: test as a negation of its characterSet instVar includes: |
||||||||
Attached Files |
![]() ![]() ![]() ![]() ![]() ![]() |
||||||||
|
![]() |
|||||||||||
|
![]() |
|
(0010463 - 52 - 58 - 58 - 58 - 58 - 58) nicolas cellier 03-23-07 01:31 |
Test and patch added. Any volunteer to cross check? |
(0011439 - 141 - 159 - 369 - 369 - 369 - 369) nicolas cellier 11-15-07 20:42 |
Following http://lists.squeakfoundation.org/pipermail/squeak-dev/2007-November/122283.html [^] find a patch for CharacterSetComplement>>#hash. |
(0011447 - 142 - 148 - 148 - 148 - 148 - 148) nicolas cellier 11-19-07 22:51 |
CharacterSetComplement cannot be printed, because they refuse to #do: CharacterSetComplement-M6367-nice-printing.1.cs patches this behaviour. |
(0011448 - 441 - 622 - 750 - 750 - 750 - 750) nicolas cellier 11-19-07 23:35 |
CharacterSetComplement when created omit to do a copy. If complement is futher changed, it will change the original changeSet. Example: | cs1 cs2 | cs1 := CharacterSet separators. cs2 := cs1 complement. cs2 add: Character tab. ^cs1 includes: Character tab. CharacterSetComplement-M6367-nice-patchCopy.1.cs patches this behaviour. IF AND ONLY IF CharacterSet copy is patched itself See http://bugs.squeak.org/view.php?id=6777 [^] |
(0011450 - 106 - 112 - 112 - 112 - 112 - 112) nicolas cellier 11-20-07 00:00 |
And of course, #postCopy has to be defined too... This is CharacterSetComplement-postCopy-M6367-nice.1.cs |
(0011569 - 503 - 581 - 581 - 581 - 581 - 581) Keith_Hodges 12-17-07 17:39 |
"fix begin" Installer mantis bug: 6367 fix:'WideString-substrings-Patch.1.cs'. Installer mantis bug: 6367 fix:'CharacterSetComplement-M6367-nice-hashPatch.1.cs'. Installer mantis bug: 6367 fix:'CharacterSetComplement-M6367-nice-printing.1.cs'. Installer mantis bug: 6367 fix:'CharacterSetComplement-M6367-nice-patchCopy.1.cs'. Installer mantis bug: 6367 fix:'CharacterSetComplement-postCopy-M6367-nice.1.cs'. "fix test" Installer mantis bug: 6367 fix:'WideString-substrings-Test.1.cs'. "fix end" |
(0012334 - 14 - 14 - 14 - 14 - 14 - 14) noha 07-04-08 06:23 |
in pharo 10049 |
(0012566 - 375 - 411 - 589 - 589 - 589 - 589) KenCausey 09-01-08 18:04 |
http://ftp.squeak.org/updates/7073CollectionAndCollectionTest.cs [^] (for 3.10) harvests WideString-substrings-Test.1.cs, WideString-substrings-Patch.1.cs, CharacterSetComplement-M6367-nice-hashPatch.1.cs, CharacterSetComplement-M6367-nice-patchCopy.1.cs, and CharacterSetComplement-postCopy-M6367-nice.1.cs but NOT CharacterSetComplement-M6367-nice-printing.1.cs *sigh* |
(0012570 - 118 - 118 - 118 - 210 - 210 - 210) nicolas cellier 09-02-08 07:40 |
Since CharacterSetComplement-M6367-nice-printing.1.cs has not been harvested, printString bug is now reported at 0007175 |
(0012604 - 106 - 106 - 106 - 198 - 198 - 198) KenCausey 09-09-08 15:06 |
Thank you Nicolas. Most patches harvested with update 7073 and released in 3.10. See 0007175 for followup. |
(0013308 - 260 - 296 - 456 - 456 - 456 - 456) nicolas cellier 09-15-09 19:14 |
Strange, 3 changes were missing in trunk. CharacterSetComplement-M6367-nice-hashPatch.1.cs CharacterSetComplement-M6367-nice-patchCopy.1.cs CharacterSetComplement-postCopy-M6367-nice.1.cs Fixed in http://source.squeak.org/trunk/Collections-nice.133.mcz [^] |
Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
111 total queries executed. 59 unique queries executed. |