0006429: [Fix ] Test suite could not run tests because they didn't follow naming convention.

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0006429

[Squeak] Morphic

major

always

04-18-07 20:22

09-08-08 17:37

Reporter

wiz

View Status

public

Assigned To

Priority

normal

Resolution

fixed

Status

closed

Product Version

3.10

Summary

0006429: [Fix ] Test suite could not run tests because they didn't follow naming convention.

Description

Some tests I wrote did not follow the Test Suite convention of starting runnable methods with 'test*'
.
The tests worked when hand invoked but would not run as a suite.

Additional Information

I was not aware of the convention when I wrote the original tests.

So I have renamed them and added them below.

When they finally run they detected two bugs.

One is the workspace bug I am still trying to get fixed.

The other was a missed patch for T...Morph>#heanding:

I will include that here and also in its own report.

So three change sets.
1) add the correctly named tests.
2) remove the old incorrectly named tests
3) patch for the #heading bug (included here for convience of harvesters)

Attached Files

testRenameFix-wiz.1.cs [^] (4,027 bytes) 04-18-07 20:22

removeOldTests-wiz.1.cs [^] (737 bytes) 04-18-07 20:23

setHeadingFix-wiz.1.cs [^] (487 bytes) 04-18-07 20:23

MoreTestRenameFixes.1.cs [^] (462 bytes) 06-12-07 00:38

Relationships

SYSTEM WARNING: Creating default object from empty value

related to	0005567	closed		hand targetOffset has been misused more times than it has been used correctly.
related to	0005619	closed	wiz	{Fix] [Test] In 7067 (and before) sending #heading to a TransformationMorph w/o a rendee recurses infinitly
related to	0004654	closed	KenCausey	In 7054 the workspace bug reported in Mantis 0002993 has reappeared.

Notes
(0010800 - 176 - 212 - 212 - 212 - 212 - 212) wiz 06-12-07 00:41	Uploaded: MoreTestRenameFixes.1.cs from preamble: Misnamed #setUp in MorphicUIBugTest fixed here and #setup removed. All four uploads should be used when fixing things.

(0010874 - 55 - 55 - 55 - 55 - 55 - 55) edgardec 07-12-07 18:03	This is 7116setHeadingFix-wiz-1.1.cs now, thanks Jerome

(0012593 - 44 - 44 - 44 - 44 - 44 - 44) KenCausey 09-08-08 17:37	harvested as update 7116 and release in 3.10

Issue History
Date Modified	Username	Field	Change
04-18-07 20:22	wiz	New Issue
04-18-07 20:22	wiz	File Added: testRenameFix-wiz.1.cs
04-18-07 20:23	wiz	File Added: removeOldTests-wiz.1.cs
04-18-07 20:23	wiz	File Added: setHeadingFix-wiz.1.cs
04-18-07 20:26	wiz	Relationship added	related to 0005619
04-18-07 20:39	wiz	Relationship added	related to 0004654
06-03-07 05:47	wiz	Relationship added	related to 0005567
06-12-07 00:38	wiz	File Added: MoreTestRenameFixes.1.cs
06-12-07 00:41	wiz	Note Added: 0010800
07-12-07 18:03	edgardec	Note Added: 0010874
10-10-07 10:09	edgardec	Status	new => resolved
09-08-08 17:37	KenCausey	Status	resolved => closed
09-08-08 17:37	KenCausey	Note Added: 0012593
09-08-08 17:37	KenCausey	Resolution	open => fixed
09-08-08 17:37	KenCausey	Fixed in Version	=> 3.10

Mantis 1.0.8[^]

68 total queries executed.
43 unique queries executed.