Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0006433 [Squeak] Morphic minor always 04-20-07 08:00 04-21-07 10:20
Reporter sig View Status public  
Assigned To
Priority normal Resolution open  
Status new   Product Version
Summary 0006433: bug in IndentingListItemMorph>>drawLinesOn
Description the error is in this part of method:
--
clippedCanvas isVisible: submorph nextSibling
--

isVisible expects a Rectange to be passed as param, while
"submorph nextSibling" returns a Morph, which does not understand #origin message.

the fix is simple, replace string before by following:
--
clippedCanvas isVisible: submorph nextSibling fullBounds
--
Additional Information
Attached Files  SimpleHierarchicalListMorph-drawLinesOn.st [^] (705 bytes) 04-21-07 10:18

- Relationships

- Notes
(0010595 - 536 - 596 - 596 - 596 - 596 - 596)
wiz
04-21-07 04:51

Hi Sig

Thank you for finding the bug.

The next step would be to upload a changeset (or method fileout) with the fix. That gives the harvesters something to work with and the rest of us something to try out.

The even better way to help is to also write a sunit test. The test should fail before the patch and pass afterwords. Tests are not that hard to make. Look at the system catagory Tests-Bugs for examples.

Again thanks for your enthusiam and keen powers of observation.

Yours in curiosity and service, --Jerome Peace
 
(0010596 - 139 - 157 - 157 - 157 - 157 - 157)
sig
04-21-07 10:20

sorry i mistaken, pointing to wrong class, please fix it on SimpleHierarchicalListMorph>>drawLinesOn:

the fixed method in the attachment
 

- Issue History
Date Modified Username Field Change
04-20-07 08:00 sig New Issue
04-20-07 08:00 sig Status new => assigned
04-20-07 08:00 sig Assigned To  => KenCausey
04-20-07 19:25 KenCausey Assigned To KenCausey =>
04-20-07 19:25 KenCausey Status assigned => new
04-20-07 19:25 KenCausey Category Any => Morphic
04-21-07 04:51 wiz Note Added: 0010595
04-21-07 10:18 sig File Added: SimpleHierarchicalListMorph-drawLinesOn.st
04-21-07 10:20 sig Note Added: 0010596


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
44 total queries executed.
33 unique queries executed.
Powered by Mantis Bugtracker