0006478: Setting up a global variable as a class alias breaks change-compression

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0006478

[Squeak] System

minor

always

05-09-07 07:44

04-18-10 21:55

Reporter

aran

View Status

public

Assigned To

andreas

Priority

normal

Resolution

fixed

Status

closed

Product Version

3.9

Summary

0006478: Setting up a global variable as a class alias breaks change-compression

Description

Perhaps it's a misguided thing to do, but if you set up a global variable to refer to a class - e.g.,

   SimpleMorphForDemo := RulerMorph

and then try to condenseChanges, RulerMorph appears twice in the list of classes. On the second attempt to process the class, everything goes pear-shaped. A crash in the middle of condensing changes is, of course, quite disconcerting.

I think this can be fixed by a small change to SystemDictionary>>classNames -

replace
  cachedClassNames _ names asSortedCollection].
with
  cachedClassNames _ names asIdentitySet asSortedCollection].

I'm still living in the pre-Traits world, but perhaps a similar fix would make sense for traitNames too.

Additional Information

Attached Files

Relationships

child of

0007480

feedback

Issues that should be fixed in 4.1

Notes
(0013601 - 29 - 29 - 29 - 29 - 29 - 29) andreas 03-30-10 04:06	Fixed in 4.1 (System-ar.304).

Issue History
Date Modified	Username	Field	Change
05-09-07 07:44	aran	New Issue
03-30-10 04:06	andreas	Relationship added	child of 0007480
03-30-10 04:06	andreas	Status	new => resolved
03-30-10 04:06	andreas	Fixed in Version	=> trunk
03-30-10 04:06	andreas	Resolution	open => fixed
03-30-10 04:06	andreas	Assigned To	=> andreas
03-30-10 04:06	andreas	Note Added: 0013601
04-18-10 21:55	andreas	Status	resolved => closed

Mantis 1.0.8[^]

42 total queries executed.
33 unique queries executed.