0006495: faulty detection of download errors

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0006495

[Squeak Packages] Universes

minor

always

05-20-07 10:25

Reporter

lexspoon

View Status

public

Assigned To

Priority

normal

Resolution

open

Status

new

Summary

0006495: faulty detection of download errors

Description

David Shaffer <cdshaffer@acm.org> writes:

> In squeak-dev-beta-123 image if I load Seaside from the Package
> Universe Browser I get a walkback when trying to load
>
> 'KomServices-gk.3.mcz'
>
> The walkback is 'Error: file is too short' and, on inspecting the file
> it simply contains the text:
>
> server aborted early
>
> I'm not sure if this is an issue with the Universe config, the dev
> image or simply a temporary failure downloading this file.

I don't know about the specific case, but there is a bug here.

The difficulty is that HTTP download errors are reported in a strange
way. The core method returns a string instead of a MIMEDocument.
Then, the URL code converts the error message to a MIMEDocument that
starts with the text "error".

Errors should be reported better. One refactoring would be to make an
"DownloadError" subclass of MIMEDocument. Then, we could robustly track
which downloads are errors, without breaking compatibility with code
that simply displays the result whether it was an error or not (e.g.,
Scamper).

I do not know a quick fix. The Universes download code looks correct on inspection, but clearly there is still a problem somewhere.

Additional Information

Attached Files

Relationships

related to

0006679

resolved

lexspoon

Package universes gets confused by HTML error message

There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
05-20-07 10:25	lexspoon	New Issue
07-04-08 22:01	Keith_Hodges	Relationship added	related to 0006679

Mantis 1.0.8[^]

33 total queries executed.
27 unique queries executed.