Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0006499 [Squeak] Morphic minor always 05-22-07 20:53 09-20-07 10:01
Reporter Simon Guest View Status public  
Assigned To
Priority normal Resolution open  
Status new   Product Version 3.9
Summary 0006499: Morph>>changed should call super changed
Description Morph>>changed overrides Object>>changed, but does not invoke super changed. This breaks the function of dependents, since dependent objects do not get notified of changes.

This affects 3.8 and 3.9, and the attached changeset works for both.
Additional Information
Attached Files  Morph-changed.2.cs [^] (353 bytes) 05-22-07 20:53

- Relationships

- Notes
(0010745 - 236 - 248 - 248 - 248 - 248 - 248)
wiz
05-23-07 03:39

This affects a lot of classes in the morph hierarchy which may have made assumptions about what #changed will or will not do in the context of Morph.

Which is to say it would require a lot of tests to prove this repair is a safe one.
 
(0011169 - 421 - 433 - 433 - 433 - 433 - 433)
Simon Guest
09-20-07 10:01

I've just seen from discussion on Squeak-UI that there are serious performance issues around dependents, to do with WeakKeyDictionaries. The class comment for class Model (exists to provide fast dependents handling) also suggests that there is a performance pitfall here.

So maybe this was originally changed for reasons of performance, and should not be changed back. Perhaps somewhere there's someone who knows ...
 

- Issue History
Date Modified Username Field Change
05-22-07 20:53 Simon Guest New Issue
05-22-07 20:53 Simon Guest File Added: Morph-changed.2.cs
05-23-07 03:39 wiz Note Added: 0010745
09-20-07 10:01 Simon Guest Note Added: 0011169


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
38 total queries executed.
29 unique queries executed.
Powered by Mantis Bugtracker