Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0006548 [Squeak] Tools minor always 06-28-07 10:47 03-30-13 21:39
Reporter cdrick View Status public  
Assigned To FrankShearar
Priority normal Resolution open  
Status testing   Product Version 3.9
Summary 0006548: [BUG][FIX]StringHolder>>browseMethodFull - doesn't use the default browser
Description In an object explorer, right click then browse on a node opens the default browser even if your default browser is different (Omnibrowser, PackagePaneBrowser...).

It comes from #browseMethodFull in StringHolder (extension of the Tools package) which doesn't use the generic tool dispatch.

I changed:
Browser fullOnClass: myClass selector: self selectedMessageName
with:
ToolSet browse: myClass selector: self selectedMessageName.

see provided change set
Additional Information
Attached Files  StringHolder-browseMethodFull.st [^] (392 bytes) 06-28-07 10:47

- Relationships

- Notes
(0010840 - 172 - 202 - 202 - 202 - 202 - 202)
cdrick
06-28-07 10:53

sorry, bad description and I don't know how to edit... if someone can do that...

Should be:

[BUG][FIX]StringHolder>>browseMethodFull - doesn't use the default browser
 
(0010841 - 243 - 267 - 267 - 267 - 267 - 267)
wiz
06-28-07 17:49

Fixed the report name.

It would be good if you could come up with a test that fails before the fix and passes after. It will help the harvesters and insure the problem doesn't sneak back in.

Yours in curiosity and service, --Jerome Peace
 
(0014345 - 241 - 253 - 253 - 253 - 253 - 253)
FrankShearar
03-30-13 21:39

Testing by virtue of pushing it into Trunk, as Tools-fbs.459. Works on the default Browser.

Tests would be great, but we'd have to build an enormous amount of testing infrastructure before we could write such a test... for a one-line fix.
 

- Issue History
Date Modified Username Field Change
06-28-07 10:47 cdrick New Issue
06-28-07 10:47 cdrick File Added: StringHolder-browseMethodFull.st
06-28-07 10:53 cdrick Note Added: 0010840
06-28-07 17:46 wiz Summary String => [BUG][FIX]StringHolder>>browseMethodFull - doesn't use the default browser
06-28-07 17:49 wiz Note Added: 0010841
03-30-13 21:39 FrankShearar Note Added: 0014345
03-30-13 21:39 FrankShearar Assigned To  => FrankShearar
03-30-13 21:39 FrankShearar Status new => testing


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
46 total queries executed.
35 unique queries executed.
Powered by Mantis Bugtracker