0006652: WeakRegistry tuning

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0006652

[Squeak] Collections

tweak

always

09-03-07 01:59

02-06-11 23:48

Reporter

sig

View Status

public

Assigned To

leves

Priority

normal

Resolution

fixed

Status

closed

Product Version

3.10

Summary

0006652: WeakRegistry tuning

Description

This patch should improve speed of WeakRegistry>>finalizeValues method.
It scans dictionary only once for keys=nil, and collecting values to finalize at same time.
Old version scans dictionary 1 time, only if there is no values to finalize, but if yes, then two times, and also uses #includes: which does not add any speed.

Additional Information

Attached Files

WeakRegistry-tuning.2.cs [^] (1,274 bytes) 09-03-07 01:59

Relationships

Notes
(0013910 - 80 - 80 - 80 - 80 - 80 - 80) leves 11-07-10 02:25	This issue was solved in Squeak 4.1, but it uses a bit different implementation.

Issue History
Date Modified	Username	Field	Change
09-03-07 01:59	sig	New Issue
09-03-07 01:59	sig	File Added: WeakRegistry-tuning.2.cs
09-21-07 15:22	tim	Status	new => assigned
09-21-07 15:22	tim	Assigned To	=> tim
09-23-07 23:41	lewis	Issue Monitored: lewis
12-28-07 18:17	tim	Assigned To	tim =>
11-07-10 02:25	leves	Status	assigned => resolved
11-07-10 02:25	leves	Fixed in Version	=> 4.1
11-07-10 02:25	leves	Resolution	open => fixed
11-07-10 02:25	leves	Assigned To	=> leves
11-07-10 02:25	leves	Note Added: 0013910
02-06-11 23:48	leves	Status	resolved => closed

Mantis 1.0.8[^]

46 total queries executed.
33 unique queries executed.