Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0000666 [Squeak] Compiler major always 12-14-04 22:49 01-07-05 20:09
Reporter tim View Status public  
Assigned To andreas
Priority normal Resolution fixed  
Status closed   Product Version 3.8
Summary 0000666: Variable spelling correction fails if SharedPool used by class or parents
Description The spelling correction code assumes shared poools are dictionaires. They aren't. Thus the code in Class>possibleVariablesFor:continuedFrom: fails because #keysDo: is not understood by a SharedPool.

The attached change fixes that with asimple method but I suggest that this is a temporary fix until someone has time to finally make all the shared pools into SharedPool classes, then fix the problem properly.

The attached does at least stop a crash.
Additional Information
Attached Files  SharedPoolSpellingFix.1.cs.gz [^] (629 bytes) 12-14-04 22:51

- Relationships

- Notes
(0000935 - 219 - 219 - 219 - 219 - 219 - 219)
tim
12-16-04 04:17

As the only other person likely to have looked at the SharedPools code, your opinion would be appreciated. I think a simple fix is needed for 3.8 so if you agree withthis jsut resolve it and let;s get the code in there.
 
(0000937 - 203 - 203 - 203 - 203 - 203 - 203)
andreas
12-16-04 06:31

Agreed. It's a simple enough fix and although I don't like it that much it is definitely less intrusive than fixing the senders or somesuch (and then I am even unsure if I'd know how to fix the senders).
 
(0000938 - 223 - 223 - 223 - 223 - 223 - 223)
tim
12-16-04 07:40

Best resolution is to add the attached change to the update stream asap. This causes a compiler crash any time a variable is misspelled in a clas with a shared pool in its inheritance tree. Not a happy thing to have around.
 
(0001018 - 29 - 29 - 29 - 29 - 29 - 29)
bert
01-07-05 20:09

6543SharedPoolSpelling-tpr.cs
 

- Issue History
Date Modified Username Field Change
12-14-04 22:49 tim New Issue
12-14-04 22:51 tim File Added: SharedPoolSpellingFix.1.cs.gz
12-16-04 04:17 tim Note Added: 0000935
12-16-04 04:17 tim Assigned To  => andreas
12-16-04 04:17 tim Status new => assigned
12-16-04 04:17 tim Description Updated
12-16-04 06:31 andreas Note Added: 0000937
12-16-04 07:40 tim Status assigned => resolved
12-16-04 07:40 tim Fixed in Version  => 3.8
12-16-04 07:40 tim Resolution open => fixed
12-16-04 07:40 tim Note Added: 0000938
01-07-05 20:09 bert Status resolved => closed
01-07-05 20:09 bert Note Added: 0001018


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
55 total queries executed.
38 unique queries executed.
Powered by Mantis Bugtracker