0006665: Bug in String>>#withoutQuoting

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0006665

[Squeak] Collections

minor

always

09-09-07 12:38

02-06-11 23:48

Reporter

JTS

View Status

public

Assigned To

leves

Priority

normal

Resolution

fixed

Status

closed

Product Version

3.10

Summary

0006665: Bug in String>>#withoutQuoting

Description

StringTest>>#testWithoutQuoting

self assert: '''hi""' withoutQuoting == '''hi""'.
self assert: '''hi' withoutQuoting == '''hi'.

These test will fail.

Additional Information

Here is the fix that passes the test:

withoutQuoting
    "remove the initial and final quote marks, if present"

    | quoteMark |
    self size < 2 ifTrue: [ ^self ].
    quoteMark := self first.
    (quoteMark = self last and: [quoteMark = $' or: [quoteMark = $"]] )
        ifTrue: [ ^self copyFrom: 2 to: self size - 1 ]
        ifFalse: [ ^self ].

Attached Files

Relationships

Notes
(0011102 - 180 - 216 - 216 - 216 - 216 - 216) wiz 09-10-07 00:22	Cool, How about submitting the fix and the tests as code uploads? That would ease the task of checking and speed harvesting. Yours in curiosity and service, --Jerome Peace

(0013936 - 28 - 28 - 28 - 28 - 28 - 28) leves 11-16-10 05:48	Fixed in Collections-ul.407.

Issue History
Date Modified	Username	Field	Change
09-09-07 12:38	JTS	New Issue
09-10-07 00:22	wiz	Note Added: 0011102
11-16-10 05:48	leves	Status	new => resolved
11-16-10 05:48	leves	Fixed in Version	=> trunk
11-16-10 05:48	leves	Resolution	open => fixed
11-16-10 05:48	leves	Assigned To	=> leves
11-16-10 05:48	leves	Note Added: 0013936
02-06-11 23:48	leves	Status	resolved => closed

Mantis 1.0.8[^]

42 total queries executed.
34 unique queries executed.