Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0006734 [Squeak] Tools minor always 10-19-07 01:38 10-22-07 05:49
Reporter chris View Status public  
Assigned To
Priority normal Resolution open  
Status new   Product Version 3.9
Summary 0006734: Rectangular Block code formatting, courtesy of Refactoring Browser.
Description This change set formats your code per the well-reasoned "Rectangular Block" and "Indented Control Flow" patterns championed by Kent Beck in his book, "Smalltalk Best Practice Patterns".

I also found them referenced from Ward's site:

  http://c2.com/ppr/formatting.html [^]

To work, first make sure the Refactoring Browser is loaded. Then file in the attached change-set. It also fixes problems associated with RbFormat where, in >= 3.9 only, it was deleting comments! I think I have all of these fixed.

Additional Information Be sure to check "useRBASTForPrettyPrint" in Preferences panel.
Attached Files  RbFormat-M6734.3.9.cs.gz [^] (6,582 bytes) 10-19-07 01:40
 AST-dc.151.mcz [^] (117,122 bytes) 10-19-07 06:31
 AST-cmm.152.mcz [^] (117,187 bytes) 10-21-07 16:45

- Relationships

- Notes
(0011353 - 92 - 92 - 92 - 92 - 92 - 92)
Damien Cassou
10-19-07 06:31

I've put the changes to the RefactoringBrowser in its repository ( RefactoringEngine-dc.38).
 
(0011354 - 196 - 196 - 196 - 196 - 196 - 196)
Damien Cassou
10-19-07 06:32

I've attached the changes made to the AST package to the bug report because I can't publish them to the AST repository (don't have write access). Can someone have a look and integrate them please?
 
(0011355 - 108 - 120 - 120 - 120 - 120 - 120)
Damien Cassou
10-19-07 06:33
edited on: 10-19-07 06:34

In my opinion, the changes to ParagraphEditor are not mandatory; I may be wrong, tell me if it's the case.

 
(0011360 - 186 - 186 - 186 - 186 - 186 - 186)
chris
10-21-07 16:05

Yes, the changes to ParagraphEditor are necessary for good usability. They allow reformat to be invoked with Alt+Shift+S and don't needlessly refuse when no method category is selected.
 
(0011361 - 59 - 59 - 59 - 59 - 59 - 59)
chris
10-21-07 16:47

Just added AST-cmm.152.mcz which is merged with AST-ms.151.
 
(0011363 - 27 - 27 - 27 - 27 - 27 - 27)
Damien Cassou
10-22-07 05:49

Reminder sent to: mathk

Can you please verify this?
 

- Issue History
Date Modified Username Field Change
10-19-07 01:38 chris New Issue
10-19-07 01:40 chris File Added: RbFormat-M6734.3.9.cs.gz
10-19-07 06:31 Damien Cassou Note Added: 0011353
10-19-07 06:31 Damien Cassou File Added: AST-dc.151.mcz
10-19-07 06:32 Damien Cassou Note Added: 0011354
10-19-07 06:33 Damien Cassou Note Added: 0011355
10-19-07 06:34 Damien Cassou Note Edited: 0011355
10-21-07 16:05 chris Note Added: 0011360
10-21-07 16:45 chris File Added: AST-cmm.152.mcz
10-21-07 16:47 chris Note Added: 0011361
10-22-07 05:49 Damien Cassou Issue Monitored: mathk
10-22-07 05:49 Damien Cassou Note Added: 0011363


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
64 total queries executed.
38 unique queries executed.
Powered by Mantis Bugtracker