Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0006778 [Squeak] Collections minor always 11-20-07 01:07 04-18-10 22:04
Reporter nicolas cellier View Status public  
Assigned To andreas
Priority normal Resolution fixed  
Status closed   Product Version 3.10
Summary 0006778: SkipList copy is shallow
Description "changing the copy changes the original"
    | original copy |
    original := SkipList new.
    original at: 3 put: '3333'.
    copy := original copy.
    copy remove: 3.
    self assert: (original includes: 3).
Additional Information same as 0006777
Attached Files  SkipList-copy-Test-M6778-nice.1.cs [^] (731 bytes) 03-26-08 21:26
 SkipList-copy-Patch-M6778-nice.1.cs [^] (1,235 bytes) 03-26-08 22:58
 SkipList-copy-Patch-M6778-nice.2.cs [^] (1,263 bytes) 03-26-08 23:29

- Relationships
related to 0007359closed KenCausey SkipLists code is covered by a combination of MIT and SqueakL 

- Notes
(0011959 - 176 - 230 - 230 - 230 - 230 - 230)
nicolas cellier
03-26-08 22:59

"fix begin"
Installer mantis bug: 6778 fix:'SkipList-copy-Patch-M6778-nice.1.cs'.
"fix test".
Installer mantis bug: 6778 fix:'SkipList-copy-Test-M6778-nice.1.cs'.
"fix end"
 
(0011960 - 232 - 320 - 320 - 320 - 320 - 320)
nicolas cellier
03-26-08 23:26
edited on: 09-16-08 20:59

"Ah, my first patch is bad, i forgot sortBlock..."

"fix begin"
Installer mantis bug: 6778 fix:'SkipList-copy-Patch-M6778-nice.2.cs'.
"fix test".
Installer mantis bug: 6778 fix:'SkipList-copy-Test-M6778-nice.1.cs'.
"fix end"

 
(0013151 - 209 - 245 - 535 - 535 - 535 - 535)
KenCausey
07-04-09 18:15

I have published a version of Collections without SkipLists at

http://source.squeak.org/trunk/Collections-klc.93.mcz [^]

and SkipLists as an external package at

http://www.squeaksource.com/SkipLists.html [^]
 
(0013152 - 164 - 164 - 328 - 328 - 328 - 328)
KenCausey
07-04-09 18:23

I have included the SkipList-copy-Patch-M6778-nice.2.cs fix and SkipList-copy-Test-M6778-nice.1.cs test in http://www.squeaksource.com/skiplists/SkipLists-klc.2.mcz [^]
 
(0013329 - 239 - 239 - 239 - 239 - 239 - 239)
KenCausey
10-04-09 17:23

This was fixed basically by removing the code to which the issue replied from the base image. SkipLists reports should now go in the Squeak Packages project. And note above that this issue was fixed in an external release of the package.
 

- Issue History
Date Modified Username Field Change
11-20-07 01:07 nicolas cellier New Issue
03-26-08 21:26 nicolas cellier File Added: SkipList-copy-Test-M6778-nice.1.cs
03-26-08 22:58 nicolas cellier File Added: SkipList-copy-Patch-M6778-nice.1.cs
03-26-08 22:59 nicolas cellier Note Added: 0011959
03-26-08 23:26 nicolas cellier Note Added: 0011960
03-26-08 23:29 nicolas cellier File Added: SkipList-copy-Patch-M6778-nice.2.cs
03-26-08 23:29 nicolas cellier Note Edited: 0011960
09-16-08 20:59 nicolas cellier Note Edited: 0011960
12-17-08 04:31 Keith_Hodges Status new => acknowledged
01-10-09 02:00 Keith_Hodges Status acknowledged => pending
01-10-09 02:27 Keith_Hodges Status pending => testing
01-10-09 03:39 Keith_Hodges Status testing => resolved
01-10-09 03:39 Keith_Hodges Fixed in Version  => 3.11
01-10-09 03:39 Keith_Hodges Resolution open => fixed
01-10-09 03:39 Keith_Hodges Assigned To  => Keith_Hodges
01-10-09 03:41 Keith_Hodges Status resolved => testing
07-04-09 18:13 KenCausey Relationship added related to 0007359
07-04-09 18:15 KenCausey Note Added: 0013151
07-04-09 18:23 KenCausey Note Added: 0013152
10-03-09 19:33 Keith_Hodges Status testing => assigned
10-03-09 19:33 Keith_Hodges Assigned To Keith_Hodges => andreas
10-04-09 17:23 KenCausey Status assigned => resolved
10-04-09 17:23 KenCausey Fixed in Version 3.11 => trunk
10-04-09 17:23 KenCausey Note Added: 0013329
04-18-10 22:04 andreas Status resolved => closed


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
81 total queries executed.
44 unique queries executed.
Powered by Mantis Bugtracker