| Anonymous | Login | 01-25-2020 01:53 UTC |
| Main | My View | View Issues | Change Log | Docs |
| Viewing Issue Simple Details [ Jump to Notes ] | [ View Advanced ] [ Issue History ] [ Print ] | ||||||||
| ID | Category | Severity | Reproducibility | Date Submitted | Last Update | ||||
| 0006834 | [Squeak] Kernel | block | always | 01-04-08 23:32 | 04-18-10 22:04 | ||||
| Reporter | rootbeer | View Status | public | ||||||
| Assigned To | laza | ||||||||
| Priority | normal | Resolution | fixed | ||||||
| Status | closed | Product Version | 3.9 | ||||||
| Summary | 0006834: Delay class>>timeoutSemaphore:afterMSecs: doesn't. | ||||||||
| Description |
The implementation for Delay class>>timeoutSemaphore:afterMSecs: doesn't even use its first parameter, so it can't do what it says it does. This method should be deprecated or removed entirely. |
||||||||
| Additional Information | |||||||||
| Attached Files |
 DelaySemaphore-6834-v1-laza.06Jan0659.cs [^] (1,838 bytes) 01-06-08 06:01 |
||||||||
|
|
|||||||||
 Relationships |
|||||||||||
|
|||||||||||
|
Notes |
|
|
(0011624 - 728 - 936 - 936 - 936 - 936 - 936) wiz 01-05-08 01:51 |
Ha rootbeer, Good bug find. more data 'laza 1/30/2005 22:13 Delay class timeoutSemaphore:afterMSecs: {instance creation}' ^ (self forMilliseconds: anInteger) schedule 'jm 9/15/97 17:10 Delay class timeoutSemaphore:afterMSecs: {instance creation}' anInteger < 0 ifTrue: [self error: 'delay times cannot be negative']. ^ (self new setDelay: anInteger forSemaphore: aSemaphore) schedule are the current and former version of the method. (gleaned from sq 7053 before the new 39sources were created. strangely laza's method does not appear in any change set that sq 7053 knows about. The earlier sq 7067 shows only jm's method so laza's was definitely introduced during the 3.9 release process. |
|
(0011625 - 43 - 55 - 55 - 55 - 55 - 55) wiz 01-05-08 01:52 |
Reminder sent to: laza Hi laza, can you shed any light on this? |
|
(0011626 - 252 - 342 - 342 - 436 - 436 - 436) laza 01-05-08 07:06 |
Hm, yes I introduced this bug with 0000854. Nobody seemed to have had a look at it! :] The method should be timeoutSemaphore: aSemaphore afterMSecs: anInteger "...comment..." ^ (self new setDelay: anInteger forSemaphore: aSemaphore) schedule |
|
(0011632 - 251 - 279 - 279 - 279 - 279 - 279) laza 01-06-08 06:03 |
I've uploaded a fix for 3.9. From the preamble: "Delay>>timeoutSemaphore: aSemaphore afterMSecs: anInteger did not use aSemaphore. This changeset reverts the method to use the provided semaphore again. It also contains a testSemaphore in DelayTest" |
|
(0012220 - 99 - 131 - 131 - 131 - 131 - 131) Keith_Hodges 05-29-08 16:06 |
"fix begin" Installer mantis bug: 6834 fix: 'DelaySemaphore-6834-v1-laza.06Jan0659.cs'. "fix end" |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 01-04-08 23:32 | rootbeer | New Issue | |
| 01-04-08 23:39 | rootbeer | Issue Monitored: rootbeer | |
| 01-05-08 01:51 | wiz | Note Added: 0011624 | |
| 01-05-08 01:52 | wiz | Issue Monitored: laza | |
| 01-05-08 01:52 | wiz | Note Added: 0011625 | |
| 01-05-08 07:06 | laza | Note Added: 0011626 | |
| 01-05-08 07:21 | laza | Relationship added | related to 0000854 |
| 01-05-08 14:53 | lewis | Issue Monitored: lewis | |
| 01-06-08 06:00 | laza | version | => 3.9 |
| 01-06-08 06:01 | laza | File Added: DelaySemaphore-6834-v1-laza.06Jan0659.cs | |
| 01-06-08 06:03 | laza | Note Added: 0011632 | |
| 05-29-08 15:14 | KenCausey | Relationship added | related to 0007060 |
| 05-29-08 16:06 | Keith_Hodges | Note Added: 0012220 | |
| 05-30-08 21:02 | al | Issue Monitored: al | |
| 01-10-09 02:00 | Keith_Hodges | Status | new => pending |
| 10-07-09 04:58 | laza | Status | pending => assigned |
| 10-07-09 04:58 | laza | Assigned To | => laza |
| 10-07-09 04:58 | laza | Status | assigned => resolved |
| 10-07-09 04:58 | laza | Fixed in Version | => trunk |
| 10-07-09 04:58 | laza | Resolution | open => fixed |
| 04-18-10 22:04 | andreas | Status | resolved => closed |
| Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
82 total queries executed. 50 unique queries executed. |  |
