Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0006890 [Squeak] Morphic tweak always 02-08-08 18:47 01-10-09 02:00
Reporter matthewf View Status public  
Assigned To
Priority normal Resolution open  
Status pending   Product Version
Summary 0006890: PluggableListMorph is slow
Description PluggableListMorph caches the list it is trying to display, so that the model doesn't need to continually re-generate the list. However, the cache is not used very effectively, so the PluggableListMorph can ask it's model up to 10 times to regenerate the list in a single click, mostly in order to compute the list size.
Additional Information
Attached Files  PluggableListMorph-speedup.1.cs [^] (2,800 bytes) 02-09-08 03:49

- Relationships
related to 0006466closed  LazyListMorph-listChaged fixuploaded to squeak-dev 

- Notes
(0011753 - 470 - 482 - 482 - 482 - 482 - 482)
matthewf
02-09-08 03:53

I am using the attached fix in an etoys-2.3 image, and it works good. It sped up very slow UI responses noticably. Not sure how much better it is on a faster computer than the XO, which is where it was developed and tested. Browsers, debuggers, monticello, and change-viewers still work with this change.

What it does, is makes *EVERYTHING* in PluggableListMorph now use the cache, instead of some using it, some not. Cache is cleared whenever #updateList is called.
 
(0011754 - 89 - 121 - 121 - 121 - 121 - 121)
matthewf
02-09-08 03:56

"fix begin"
Installer mantis bug: 6890 fix: 'PluggableListMorph-speedup.1.cs'
"fix end"
 
(0011977 - 478 - 514 - 678 - 678 - 678 - 678)
matthewf
04-08-08 03:09

Someone put this fix in MinorFixes-unstable:
http://installer.pbwiki.org/MinorFixesUnstable-Squeak3:10 [^]
Ken Brown reports that it breaks the scrollbars in a 3.10 image, probably because the true size of a list never got computed. Not sure how that happened, but I never tested this fix at all outside etoys.

And also, I never use the scrollbars. I always type the first letter of the entry then page up/down and arrow up/down

So, I'll remove this from minorfixes-unstable
 
(0011978 - 394 - 428 - 556 - 556 - 556 - 556)
kbrown
04-08-08 03:20

As part of LPF + MinorFixesUnstable, loading 6890 into sq3.10-7159dev08.04.1appears to cause an anomaly with System Browser, the System Browser scrollbars no longer work, they extend the full length. The scroll arrows appear to work however.

Offending Installer script entry is:
" http://bugs.squeak.org/view.php?id=6890 [^] "
Installer mantis ensureFix: '0006890: PluggableListMorph is slow'.
 
(0011983 - 78 - 78 - 206 - 206 - 206 - 206)
Keith_Hodges
04-08-08 15:05

Sounds like this fix is trampling upon http://bugs.squeak.org/view.php?id=6466 [^]
 
(0011984 - 87 - 87 - 87 - 87 - 87 - 87)
matthewf
04-08-08 18:17

Keith: You are probably right. Thanks for the lead. I'll look into this tommorrow or so
 

- Issue History
Date Modified Username Field Change
02-08-08 18:47 matthewf New Issue
02-08-08 18:47 matthewf Issue Monitored: matthewf
02-09-08 03:49 matthewf File Added: PluggableListMorph-speedup.1.cs
02-09-08 03:53 matthewf Note Added: 0011753
02-09-08 03:56 matthewf Note Added: 0011754
04-08-08 03:09 matthewf Note Added: 0011977
04-08-08 03:20 kbrown Note Added: 0011978
04-08-08 15:05 Keith_Hodges Note Added: 0011983
04-08-08 18:17 matthewf Relationship added related to 0006466
04-08-08 18:17 matthewf Note Added: 0011984
01-10-09 02:00 Keith_Hodges Status new => pending


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
63 total queries executed.
41 unique queries executed.
Powered by Mantis Bugtracker