Anonymous | Login | 02-27-2021 22:09 UTC |
Main | My View | View Issues | Change Log | Docs |
Viewing Issue Simple Details [ Jump to Notes ] | [ View Advanced ] [ Issue History ] [ Print ] | ||||||||
ID | Category | Severity | Reproducibility | Date Submitted | Last Update | ||||
0006933 | [Squeak] Collections | minor | always | 02-18-08 01:18 | 04-18-10 22:04 | ||||
Reporter | ykoubo | View Status | public | ||||||
Assigned To | andreas | ||||||||
Priority | normal | Resolution | fixed | ||||||
Status | closed | Product Version | 3.9 | ||||||
Summary | 0006933: MultiByteFileStream>>upTo: fails for binary | ||||||||
Description |
In the binary mode, MultiByteFileStream>>upTo: raises error to read non-character contents. |
||||||||
Additional Information | That method uses a String as a temporary buffur, and String could not accept non-character data. | ||||||||
Attached Files |
![]() ![]() ![]() ![]() |
||||||||
|
![]() |
|
(0011820 - 54 - 54 - 54 - 54 - 54 - 54) ykoubo 02-18-08 01:22 |
I attached a fix to use a ByteArray buffer for binary. |
(0011821 - 507 - 636 - 636 - 636 - 636 - 636) wiz 02-18-08 03:18 |
Hi ykoubo, Thanks for your report and fix. Can you provide an sunit test that fails before the patch and works after. testBinaryUpTo: <something> self shouldnt: [ <something that failed ] raise: Error etc would be the likely pattern. Also any other good tortures for the streams you can think of would probably helpful. The test will help harvesters know your fix works. Also your test will prevent the fix from getting undone. Yours in service and curiosity, --Jerome Peace |
(0011871 - 194 - 260 - 260 - 260 - 260 - 260) nicolas cellier 02-25-08 21:02 edited on: 04-06-08 16:47 |
"fix begin" Installer mantis bug: 6933 fix:'MultiByteFileStream-binaryUpTo.1.cs'. "fix test" Installer mantis bug: 6933 fix:'MultiByteFileStream-binaryUpTo-M6933-Test-nice.1.cs'. "fix end" |
(0012745 - 210 - 249 - 249 - 249 - 249 - 249) nicolas cellier 10-17-08 19:19 edited on: 10-17-08 19:22 |
I reviewed more carefully for Pharo, and saw that: 1) my test was wrong (1 2 3 4) upTo: 3 -> (1 2) (upTo: is excluding delimiter) 2) ky patch has a remaining ^'' So please find updates proposed in Pharo |
(0012746 - 212 - 266 - 266 - 266 - 266 - 266) nicolas cellier 10-17-08 19:22 |
"fix begin" Installer mantis bug: 6933 fix:'MultiByteFileStream-binaryUpTo-M6933-Patch-ky-nice.2.cs'. "fix test" Installer mantis bug: 6933 fix:'MultiByteFileStream-binaryUpTo-M6933-Test-nice.2.cs'. "fix end" |
(0013333 - 128 - 134 - 452 - 452 - 452 - 452) nicolas cellier 10-04-09 18:52 |
Fixed in http://source.squeak.org/trunk/Multilingual-cbc.47.mcz [^] then in http://source.squeak.org/trunk/Multilingual-nice.49.mcz [^] |
Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
84 total queries executed. 46 unique queries executed. |