Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0006933 [Squeak] Collections minor always 02-18-08 01:18 04-18-10 22:04
Reporter ykoubo View Status public  
Assigned To andreas
Priority normal Resolution fixed  
Status closed   Product Version 3.9
Summary 0006933: MultiByteFileStream>>upTo: fails for binary
Description In the binary mode, MultiByteFileStream>>upTo: raises error to read non-character contents.
Additional Information That method uses a String as a temporary buffur, and String could not accept non-character data.
Attached Files  MultiByteFileStream-binaryUpTo.1.cs [^] (532 bytes) 02-18-08 01:20
 MultiByteFileStream-binaryUpTo-M6933-Test-nice.1.cs [^] (1,052 bytes) 02-19-08 22:01
 MultiByteFileStream-binaryUpTo-M6933-Patch-ky-nice.2.cs [^] (781 bytes) 10-17-08 19:20
 MultiByteFileStream-binaryUpTo-M6933-Test-nice.2.cs [^] (981 bytes) 10-17-08 19:20

- Relationships

- Notes
(0011820 - 54 - 54 - 54 - 54 - 54 - 54)
ykoubo
02-18-08 01:22

I attached a fix to use a ByteArray buffer for binary.
 
(0011821 - 507 - 636 - 636 - 636 - 636 - 636)
wiz
02-18-08 03:18

Hi ykoubo,

Thanks for your report and fix.

Can you provide an sunit test that fails before the patch and works after.

testBinaryUpTo:
<something>
self shouldnt: [ <something that failed ] raise: Error

etc

would be the likely pattern.

Also any other good tortures for the streams you can think of would probably helpful.

The test will help harvesters know your fix works.

Also your test will prevent the fix from getting undone.

Yours in service and curiosity, --Jerome Peace
 
(0011871 - 194 - 260 - 260 - 260 - 260 - 260)
nicolas cellier
02-25-08 21:02
edited on: 04-06-08 16:47

"fix begin"
Installer mantis bug: 6933 fix:'MultiByteFileStream-binaryUpTo.1.cs'.
"fix test"
Installer mantis bug: 6933 fix:'MultiByteFileStream-binaryUpTo-M6933-Test-nice.1.cs'.
"fix end"

 
(0012745 - 210 - 249 - 249 - 249 - 249 - 249)
nicolas cellier
10-17-08 19:19
edited on: 10-17-08 19:22

I reviewed more carefully for Pharo, and saw that:
1) my test was wrong (1 2 3 4) upTo: 3 -> (1 2) (upTo: is excluding delimiter)
2) ky patch has a remaining ^''

So please find updates proposed in Pharo

 
(0012746 - 212 - 266 - 266 - 266 - 266 - 266)
nicolas cellier
10-17-08 19:22

"fix begin"
Installer mantis bug: 6933 fix:'MultiByteFileStream-binaryUpTo-M6933-Patch-ky-nice.2.cs'.
"fix test"
Installer mantis bug: 6933 fix:'MultiByteFileStream-binaryUpTo-M6933-Test-nice.2.cs'.
"fix end"
 
(0013333 - 128 - 134 - 452 - 452 - 452 - 452)
nicolas cellier
10-04-09 18:52

Fixed in http://source.squeak.org/trunk/Multilingual-cbc.47.mcz [^]
then in http://source.squeak.org/trunk/Multilingual-nice.49.mcz [^]
 

- Issue History
Date Modified Username Field Change
02-18-08 01:18 ykoubo New Issue
02-18-08 01:20 ykoubo File Added: MultiByteFileStream-binaryUpTo.1.cs
02-18-08 01:22 ykoubo Note Added: 0011820
02-18-08 03:18 wiz Note Added: 0011821
02-19-08 22:01 nicolas cellier File Added: MultiByteFileStream-binaryUpTo-M6933-Test-nice.1.cs
02-25-08 21:02 nicolas cellier Note Added: 0011871
04-06-08 16:47 nicolas cellier Note Edited: 0011871
10-17-08 19:19 nicolas cellier Note Added: 0012745
10-17-08 19:20 nicolas cellier File Added: MultiByteFileStream-binaryUpTo-M6933-Patch-ky-nice.2.cs
10-17-08 19:20 nicolas cellier File Added: MultiByteFileStream-binaryUpTo-M6933-Test-nice.2.cs
10-17-08 19:22 nicolas cellier Note Added: 0012746
10-17-08 19:22 nicolas cellier Note Edited: 0012745
12-17-08 04:52 Keith_Hodges Severity crash => minor
12-17-08 04:52 Keith_Hodges Category Kernel => Collections
12-17-08 04:52 Keith_Hodges Status new => acknowledged
01-10-09 02:00 Keith_Hodges Status acknowledged => pending
01-10-09 02:27 Keith_Hodges Status pending => testing
01-10-09 03:39 Keith_Hodges Status testing => resolved
01-10-09 03:39 Keith_Hodges Fixed in Version  => 3.11
01-10-09 03:39 Keith_Hodges Resolution open => fixed
01-10-09 03:39 Keith_Hodges Assigned To  => Keith_Hodges
01-10-09 03:41 Keith_Hodges Status resolved => testing
10-03-09 19:33 Keith_Hodges Status testing => assigned
10-03-09 19:33 Keith_Hodges Assigned To Keith_Hodges => andreas
10-04-09 18:52 nicolas cellier Status assigned => resolved
10-04-09 18:52 nicolas cellier Fixed in Version 3.11 => trunk
10-04-09 18:52 nicolas cellier Note Added: 0013333
04-18-10 22:04 andreas Status resolved => closed


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
84 total queries executed.
46 unique queries executed.
Powered by Mantis Bugtracker