0006941: should use #keysAndValuesDo: instead of #withIndexDo:

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0006941

[Squeak Packages] Seaside

minor

always

02-21-08 08:36

02-21-08 09:49

Reporter

renggli

View Status

public

Assigned To

renggli

Priority

normal

Resolution

fixed

Status

resolved

Summary

0006941: should use #keysAndValuesDo: instead of #withIndexDo:

Description

The former is in ANSI, the latter is not.

I checked that both Squeak and VW have it.

The methods are:
- WAExternalIDTest>>#fromString: which BTW is not covered by the tests;
the test could be as simple as

str := 'abCD12_-'.
self assert: (WAExternalID fromString: str) printString = str

- Object>>#inspectorFields

- WADateTable>>#renderContentsOn:

- WADateTable>>#renderRowsOn:

Thanks,

Paolo

Additional Information

Attached Files

Relationships

Notes
(0011852 - 655 - 787 - 787 - 787 - 787 - 787) renggli 02-21-08 09:49	Name: Seaside-Core-lr.58 Author: lr Time: 21 February 2008, 10:37:43 am UUID: 1621bb7a-d492-44a2-867b-309b7c660f9b Ancestors: Seaside-Core-lr.57 - replaced #withIndexDo: with #keysAndValuesDo: Name: Seaside-Development-Core-lr.11 Author: lr Time: 21 February 2008, 10:37:55 am UUID: 3cf7fd03-4c32-4e17-b4b2-a6c74034490c Ancestors: Seaside-Development-Core-lr.10 - replaced #withIndexDo: with #keysAndValuesDo: Name: Seaside-Squeak-Development-lr.5 Author: lr Time: 21 February 2008, 10:38:13 am UUID: dcdd1f83-51f5-4913-9b72-08aba6257aa8 Ancestors: Seaside-Squeak-Development-lr.4 - replaced #withIndexDo: with #keysAndValuesDo:

Issue History
Date Modified	Username	Field	Change
02-21-08 08:36	renggli	New Issue
02-21-08 08:36	renggli	Status	new => assigned
02-21-08 08:36	renggli	Assigned To	=> renggli
02-21-08 09:49	renggli	Status	assigned => resolved
02-21-08 09:49	renggli	Resolution	open => fixed
02-21-08 09:49	renggli	Note Added: 0011852

Mantis 1.0.8[^]

35 total queries executed.
29 unique queries executed.