0007090: TraitsTests pollutes ProtoObject subclasses

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0007090

[Squeak] Traits

minor

always

06-11-08 16:56

04-18-10 22:04

Reporter

noha

View Status

public

Assigned To

laza

Priority

normal

Resolution

fixed

Status

closed

Product Version

Summary

0007090: TraitsTests pollutes ProtoObject subclasses

Description

In SetUp Phase for TraitsTests (TraitsResource) classes are created. On this class the superclass is deleted manually via superclass: nil.
The classes are removed/obsoleted afterwards but as there is no superclass it can't be deleted from superclass subclasses.

All classes are created as subclass of ProtoObject. So the subclasses array of ProtoObject gets polluted by running the TraitsTest. I'll attach a fix which also calls ProtoObject removeSubclass: xxx

Additional Information

Attached Files

TraitsTestSubclassesCleanup-M7090.1.cs [^] (2,347 bytes) 06-11-08 16:57

Relationships

Notes
(0013356 - 421 - 554 - 800 - 800 - 800 - 800) lewis 10-06-09 02:00	From: Adrian Lienhard <adi@netstyle.ch> To: The general-purpose Squeak developers list <squeak-dev@lists.squeakfoundation.org> Subject: Re: [squeak-dev] ClassTraitTest pollutes system Date: Mon, 5 Oct 2009 20:41:54 +0200 Isn't this mantis issue 7090? You may also want to check how we fixed this over at Pharo (more than a year ago): http://code.google.com/p/pharo/issues/detail?id=13 [^] HTH, Adrian

(0013357 - 111 - 111 - 111 - 111 - 111 - 111) noha 10-06-09 06:55	That is the same fix. I did it originally in pharo and then I added it to mantis so that squeak can fix it, too

(0013362 - 36 - 36 - 36 - 36 - 36 - 36) laza 10-07-09 04:46	I filed the changeset into the trunk

Issue History
Date Modified	Username	Field	Change
06-11-08 16:56	noha	New Issue
06-11-08 16:56	noha	Status	new => assigned
06-11-08 16:56	noha	Assigned To	=> dvf
06-11-08 16:57	noha	File Added: TraitsTestSubclassesCleanup-M7090.1.cs
10-06-09 02:00	lewis	Note Added: 0013356
10-06-09 02:01	lewis	Issue Monitored: lewis
10-06-09 06:55	noha	Note Added: 0013357
10-07-09 04:45	laza	Assigned To	dvf => laza
10-07-09 04:46	laza	Status	assigned => resolved
10-07-09 04:46	laza	Fixed in Version	=> trunk
10-07-09 04:46	laza	Resolution	open => fixed
10-07-09 04:46	laza	Note Added: 0013362
04-18-10 22:04	andreas	Status	resolved => closed

Mantis 1.0.8[^]

54 total queries executed.
38 unique queries executed.