|Anonymous | Login||04-04-2020 09:43 UTC|
|Main | My View | View Issues | Change Log | Docs|
|Viewing Issue Simple Details [ Jump to Notes ]||[ View Advanced ] [ Issue History ] [ Print ]|
|ID||Category||Severity||Reproducibility||Date Submitted||Last Update|
|0007144||[Squeak] Multilingual||minor||always||08-03-08 17:56||08-03-08 18:02|
|Summary||0007144: In Sq 7159 TTCFontSet>>pointSize is poorly coded|
The code for this method hardwires parameter constants into the method rather than refering to the authoritative settngs.
It also floors the answer. Since this message is used for other computaions this can lead to truncation/roundoff errors. And I have seen other evidence that other code seems to have been writen to get around this codes poor behavior.
'From Squeak3.10.2 of ''5 June 2008'' [latest update: 0007179] on 2 August 2008 at 11:58:13 pm'!
!TTCFontSet methodsFor: 'as yet unclassified' stamp: 'yo 11/16/2002 01:17'!
^ fontArray first pixelSize * 72 // 96.
hardwires the constants for points/inch and pixels per inch.
This is WRONG.
(0012438 - 412 - 490 - 490 - 490 - 490 - 490)
edited on: 08-03-08 18:11
are various measures for font glyphs used in different ways thru out the code.
There is major code tangle and confusion as to there use.
And I have been finding inconsistances as I review (and try to understand) the code. This is another one.
What is needed is a documentation of the rules that need to govern the meaning and use of the above terms.
|08-03-08 17:56||wiz||New Issue|
|08-03-08 17:58||wiz||Relationship added||child of 0006570|
|08-03-08 18:02||wiz||Note Added: 0012438|
|08-03-08 18:11||wiz||Note Edited: 0012438|
| Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
41 total queries executed.|
30 unique queries executed.