Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0007177 [Squeak] Collections minor always 09-03-08 14:06 04-18-10 22:04
Reporter Keith_Hodges View Status public  
Assigned To andreas
Priority normal Resolution fixed  
Status closed   Product Version 3.10.2
Summary 0007177: removeAll fails for Dictionaries
Description The standard implementation of #removeAll is slow, and doesnt cover any of the varieties of Dictionary. Simply replacing #removeAll with an initialize solves both of these problems
Additional Information
Attached Files  Set-Dictionary-fast-removeAll-M7177.1.cs [^] (205 bytes) 09-03-08 14:07
 M7177-Collection-removeAll-nice-Patch.1.cs [^] (3,806 bytes) 01-10-09 00:04

- Relationships
related to 0006937closed kwl removeAll: aCollection doesn't do what we expect if aCollection==self 

- Notes
(0012578 - 99 - 131 - 131 - 131 - 131 - 131)
Keith_Hodges
09-03-08 14:08

"fix begin"
Installer mantis bug: 7177 fix: 'Set-Dictionary-fast-removeAll-M7177.1.cs'.
"fix end"
 
(0012909 - 238 - 262 - 262 - 382 - 382 - 382)
nicolas cellier
01-10-09 00:07

Hello Keith, I did not check your patch before...
Maybe you can review mine in case it is more complete...
I have no #removeAll in my image. Where does it come from?

Last, I tried to address 0006937 (but defunct MappedCollection case).
 
(0013305 - 302 - 326 - 654 - 654 - 654 - 654)
nicolas cellier
09-14-09 18:51
edited on: 09-14-09 19:13

I uploaded my version in http://source.squeak.org/trunk/Collections-nice.130.mcz [^]
I added some tests in http://source.squeak.org/trunk/CollectionsTests-nice.94.mcz [^]
Keith, if you have other sources of interest (alternative or complementary removeAll implementations and tests), please provide links.

 

- Issue History
Date Modified Username Field Change
09-03-08 14:06 Keith_Hodges New Issue
09-03-08 14:07 Keith_Hodges File Added: Set-Dictionary-fast-removeAll-M7177.1.cs
09-03-08 14:08 Keith_Hodges Note Added: 0012578
01-10-09 00:04 nicolas cellier File Added: M7177-Collection-removeAll-nice-Patch.1.cs
01-10-09 00:07 nicolas cellier Note Added: 0012909
01-10-09 02:13 Keith_Hodges Status new => pending
01-10-09 02:27 Keith_Hodges Status pending => testing
01-10-09 03:40 Keith_Hodges Status testing => resolved
01-10-09 03:40 Keith_Hodges Fixed in Version  => 3.11
01-10-09 03:40 Keith_Hodges Resolution open => fixed
01-10-09 03:40 Keith_Hodges Assigned To  => Keith_Hodges
01-10-09 03:41 Keith_Hodges Status resolved => testing
09-14-09 17:26 nicolas cellier Relationship added related to 0006937
09-14-09 18:51 nicolas cellier Note Added: 0013305
09-14-09 19:13 nicolas cellier Note Edited: 0013305
10-03-09 19:33 Keith_Hodges Status testing => assigned
10-03-09 19:33 Keith_Hodges Assigned To Keith_Hodges => andreas
10-04-09 20:35 nicolas cellier Status assigned => resolved
10-04-09 20:35 nicolas cellier Fixed in Version 3.11 => trunk
04-18-10 22:04 andreas Status resolved => closed


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
66 total queries executed.
39 unique queries executed.
Powered by Mantis Bugtracker