Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0007198 [Squeak] Multilingual minor always 09-22-08 20:36 09-22-08 20:36
Reporter wiz View Status public  
Assigned To
Priority normal Resolution open  
Status new   Product Version
Summary 0007198: basicNext:into: is an unsent message that sends unnecessarily to super.
Description 'yo 8/28/2002 11:07 MultiByteFileStream basicNext:into: {private basic}'
'yo 11/11/2002 13:21 MultiByteBinaryOrTextStream basicNext:into: {private basic}'

basicNext: n into: aString

    ^ super next: n into: aString.

there is only one implementor of super in the hierarchy so a simple
self next: n into: aString would have done.

There are 3 problems here.
first a basic... message is calling on the non-basic message. That seems odd to me and cause the rest of the investigation.
second it is an unsent message. Which means there is no sunit test covering it.
third it is using the super call incorrectly since it does not override next into.

These are all invitations to trouble if ever someone thinks they should call the method.

I do not know what the proper fix is but I suspect that the 'your not going to need it' principle applies here and that the unsent messages in these classes should be removed.

If thats not the case then at least think about writing tests for them to illustrate their use.

I did my research in 3.10.2 but I have looked at etoys 3.0 and that has the same thing going on.

Yours in curiosity and service, --Jerome Peace
Additional Information From 3.10.2 0007179 I got the following lists of unsent messages in the two classes.


MultiByteBinaryOrTextStream unsent messages:

#('MultiByteBinaryOrTextStream asBinaryOrTextStream {converting}' 'MultiByteBinaryOrTextStream basicNext: {private basic}'
 'MultiByteBinaryOrTextStream basicNext:into: {private basic}'
 'MultiByteBinaryOrTextStream basicNextInto: {private basic}'
 'MultiByteBinaryOrTextStream basicPeek {private basic}'
 'MultiByteBinaryOrTextStream basicPosition {private basic}'
 'MultiByteBinaryOrTextStream basicPosition: {private basic}'
 'MultiByteBinaryOrTextStream guessConverter {private}'
 'MultiByteBinaryOrTextStream setEncoderForSourceCodeNamed: {fileIn/Out}'
 'MultiByteBinaryOrTextStream class with:encoding: {instance creation}')


MultiByteFileStream unsent messages:

#('MultiByteFileStream accepts: {remnant}'
 'MultiByteFileStream basicNext: {private basic}'
 'MultiByteFileStream basicNext:into: {private basic}'
 'MultiByteFileStream basicNextInto: {private basic}'
 'MultiByteFileStream basicPeek {private basic}'
 'MultiByteFileStream basicPosition {private basic}'
 'MultiByteFileStream basicPosition: {private basic}'
 'MultiByteFileStream basicReadInto:startingAt:count: {private basic}'
 'MultiByteFileStream basicSetToEnd {private basic}'
 'MultiByteFileStream basicSkip: {private basic}'
 'MultiByteFileStream basicUpTo: {private basic}'
 'MultiByteFileStream basicVerbatim: {private basic}'
 'MultiByteFileStream convertStringToCr: {crlf private}'
 'MultiByteFileStream fileInEncodingName: {accessing}'
 'MultiByteFileStream filterFor: {remnant}'
 'MultiByteFileStream lineEndConvention {accessing}'
 'MultiByteFileStream lineEndConvention: {accessing}')
Attached Files

- Relationships

There are no notes attached to this issue.

- Issue History
Date Modified Username Field Change
09-22-08 20:36 wiz New Issue


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
28 total queries executed.
25 unique queries executed.
Powered by Mantis Bugtracker