0007238: SmartSyntaxPluginTMethod>>nullReturnExpr relies on #define null, may conflict with other libraries

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0007238

[Squeak] VM

minor

always

12-01-08 23:44

12-01-08 23:46

Reporter

lewis

View Status

public

Assigned To

lewis

Priority

low

Resolution

open

Status

assigned

Product Version

Summary

0007238: SmartSyntaxPluginTMethod>>nullReturnExpr relies on #define null, may conflict with other libraries

Description

In Cross/vm/sq.h we have:
#define null 0 /* using "null" because nil is predefined in Think C */

This is used as a return value in #nullReturnExpr, and presumably elsewhere.
However, this definition has been reported to conflict with other code bases, as reported by:
http://lists.squeakfoundation.org/pipermail/vm-dev/2008-October/002053.html [^]

Some value other than 'null' (e.g. 'sqNull') might prevent this problem.

Additional Information

From the vm-dev list (estebanlm at gmail.com):
Hi,
I had to change null output for squeak generated plugins (it was
colliding with other libraries needed) and I found this:

SmartSyntaxPluginTMethod>>nullReturnExpr
    ^ TReturnNode new
        setExpression: (TVariableNode new setName: 'null')

this generates correct return lines, but just because "null" is defined
previously. If I change null to, e.g. sqNil, the previous method still
generates "return null" lines.
So I changed the method as follows:

SmartSyntaxPluginTMethod>>nullReturnExpr
    ^ TReturnNode new
        setExpression: (TVariableNode new setName: 'nil')

just replaced "null" for "nil", and everything seems to be working
fine. Is this hack correct?

Cheers,
Esteban

Attached Files

Relationships

There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
12-01-08 23:44	lewis	New Issue
12-01-08 23:44	lewis	Status	new => assigned
12-01-08 23:44	lewis	Assigned To	=> tim
12-01-08 23:46	lewis	Assigned To	tim => lewis
07-03-09 19:49	lewis	Issue Monitored: lewis

Mantis 1.0.8[^]

33 total queries executed.
27 unique queries executed.