0007285: HTTPRequest >> #networkHost might raise MNU

Viewing Issue Simple Details [ Jump to Notes ]

[ View Advanced ] [ Issue History ] [ Print ]

Category

Severity

Reproducibility

Date Submitted

Last Update

0007285

[Squeak Packages] KomHttpServer

major

random

02-14-09 18:00

03-04-09 01:28

Reporter

pmm

View Status

public

Assigned To

gcorriga

Priority

normal

Resolution

open

Status

assigned

Summary

0007285: HTTPRequest >> #networkHost might raise MNU

Description

The following method is problematic:

networkHost

^self propertyAt: #networkHost ifAbsentPut:
[NetworkHost fromString: self host].

There is an issue when self host returns nil then NetworkHost fromString: returns an MNU:

Additional Information

Attached Files

Relationships

Notes
(0013001 - 291 - 303 - 303 - 303 - 303 - 303) gcorriga 03-04-09 01:28 edited on: 03-04-09 01:30	I didn't have the time to replicate this bug yet, but I note that according to the HTTP/1.1 RFC, every request should alway have a Host: header field (see RFC 2616 section 14.22 ). In such a case Kom should probably send a 400 Bad Request response withouth getting at all into this method.

Issue History
Date Modified	Username	Field	Change
02-14-09 18:00	pmm	New Issue
02-14-09 18:00	pmm	Status	new => assigned
02-14-09 18:00	pmm	Assigned To	=> gcorriga
03-04-09 01:28	gcorriga	Note Added: 0013001
03-04-09 01:30	gcorriga	Note Edited: 0013001

Mantis 1.0.8[^]

37 total queries executed.
29 unique queries executed.