Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0000729 [Squeak] Kernel major always 12-26-04 20:44 07-13-06 07:57
Reporter tim View Status public  
Assigned To tim
Priority normal Resolution open  
Status assigned   Product Version 3.8
Summary 0000729: Can attempt to save image with illegal filename, little chance of recovery
Description The current code to saveAs (and several siblings) makes no attempt to check the chosen new filename for propriety. This means it is possible for a user to enter an unnacceptable filename (say, including tab or whatever) that gets used to
a) try to save the changes file. This usage does go via the filename checking and will get processed by FileDirectory>checkName:fixErrors:. It is possible for this to cause errors which are not cleanly caught.
b) set the image name via SmalltalkImage>imageName: which passes the string straight to the VM. Since 3.8 the VM does have the option of rejecting this or otherwise canonicalizing it. If the VM code doesn't treat the filename exactly the same way as the FileDirectory>checkName.... method there can be a clash between the name given to the changes file and the name the image understand itself to have. There is currently no check to se if the image name has any relationship to the expected string.

Saving an image is a pretty crucial action. During the save process quite a lot of important work is done to stabilise the image and has to be backed otu of after the save is complete. An error in this area is rarely easy to recover from and unlikely to make a user happy. We should try to do better.
Additional Information
Attached Files

- Relationships

There are no notes attached to this issue.

- Issue History
Date Modified Username Field Change
12-26-04 20:44 tim New Issue
07-13-06 07:57 tim Status new => assigned
07-13-06 07:57 tim Assigned To  => tim


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
29 total queries executed.
26 unique queries executed.
Powered by Mantis Bugtracker