Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0007316 [Squeak Packages] Numerical Analysis minor always 03-16-09 13:13 03-20-09 17:52
Reporter glenpaling View Status public  
Assigned To
Priority normal Resolution open  
Status new  
Summary 0007316: Didier Besset's Numerical Analysis Replacement of String asInteger Causes Bug
Description See: 0007197: DateAndTime readFrom: Results are About 2 Seconds Early.

'2008-08-28' asDateAndTime 2008-08-27T23:59:57.999999995+00:00
'2006-08-28T00:00' asDateAndTime 2006-08-27T23:59:57.999999995+00:00.

sUnit catches this bug too. It's due to Didier Besset's Numerical Analysis package from universes. It replaces String asInteger with:

asInteger
        "(c) Copyrights Didier BESSET, all rights reserved
         Initial code: 1/6/98 "
    ^self inject: 0
            into: [ :ans :each | (ans * 10) + each digitValue]

It naively assumes that all characters are valid digits. asDateAndTime also places a plus sign into the conversion buffer. digitValue happily converts $+ to -5.

The original asInteger is coded as ^self asSignedInteger. Didier Bessets version of asInteger should be removed from the Numerical Analysis package.
Additional Information
Attached Files

- Relationships

- Notes
(0013042 - 204 - 204 - 204 - 204 - 204 - 204)
KenCausey
03-16-09 16:36

I have added a Numerical Analysis category but as far as I can tell Didier Besset has no account on this Mantis. So I recommend that you contact him directly informing him of the existence of this issue.
 
(0013044 - 145 - 145 - 145 - 145 - 145 - 145)
lexspoon
03-17-09 15:55

I'd recommend just removing the package, if Didier Besset can't be found and no one else wants to step up to maintain it. Damien, can you do it?
 
(0013052 - 244 - 256 - 394 - 394 - 394 - 394)
glenpaling
03-18-09 23:44

Joshua Gargus is listed as maintainer on Squeakmap. Home page is on sourceforge: http://sourceforge.net/projects/dhbnumerics/. [^] No activity for seven years though.

Joshua is still around as he recently posted on Squeak-Dev. I'll email him.
 
(0013054 - 329 - 329 - 329 - 329 - 329 - 329)
glenpaling
03-20-09 17:52

Joshua isn't interested. I'll volunteer to do it. I'm not up to all the math that's in the package but I can at least render it harmless by removing or renaming method overwrites. I do have the book! I see on sourceforge a newer VW version with a couple of bug fixes and some unit tests. I'll have a look bringing it into Squeak.
 

- Issue History
Date Modified Username Field Change
03-16-09 13:13 glenpaling New Issue
03-16-09 13:13 glenpaling Status new => assigned
03-16-09 13:13 glenpaling Assigned To  => KenCausey
03-16-09 16:36 KenCausey Note Added: 0013042
03-16-09 16:36 KenCausey Assigned To KenCausey =>
03-16-09 16:36 KenCausey Status assigned => new
03-16-09 16:36 KenCausey Category Any => Numerical Analysis
03-17-09 15:55 lexspoon Note Added: 0013044
03-18-09 23:44 glenpaling Note Added: 0013052
03-20-09 17:52 glenpaling Note Added: 0013054


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
50 total queries executed.
37 unique queries executed.
Powered by Mantis Bugtracker