Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0007342 [Squeak] Tools major always 04-28-09 02:04 04-09-10 19:24
Reporter wiz View Status public  
Assigned To
Priority normal Resolution open  
Status pending   Product Version 3.10.2
Summary 0007342: Change Sorters in 3.10.2 no longer report about class definitions or class comments.
Description For this one Create a changeset
with a new class and class comment.

file it out.

In a fresh 3.9 file it in and open a dual change sorter.
Install the changeset you filed out.
Select the new class in the change set.
Notice that the text feild now says
you have a new class definition and class comment.


In a fresh 3.10 try the same steps.
No notice of either the class definition or class comment appears.
Additional Information Issue 0005831 and 0004825 contain fixes that affected the changesorter.
And Andreas pointed to more so. Those are our suspects.
Attached Files  ChangeSorter-setContents.st [^] (2,029 bytes) 05-03-09 03:41
 ChangeSorter-s...OrMetaClass.st [^] (754 bytes) 06-05-09 15:24
 CSorter-fix-m7463-wiz.1.cs [^] (4,140 bytes) 03-17-10 06:58

- Relationships

SYSTEM WARNING: Creating default object from empty value

SYSTEM WARNING: Creating default object from empty value

SYSTEM WARNING: Creating default object from empty value

SYSTEM WARNING: Creating default object from empty value

related to 0005831closed  [RFE] Changesorters need to report packages of methods and Classes 
related to 0004825closed  [KernelImageOverride] ChangesOrganizer 
related to 0007412closed  Changeset sorter displays a class category against each method instead of method's category 
related to 0007463pending  In sq 8955 ChangeSorter has a multiple number of ailments 
child of 0007480feedback  Issues that should be fixed in 4.1 

- Notes
(0013109 - 166 - 196 - 196 - 313 - 313 - 313)
wiz
05-02-09 21:04

Found it.

In a fresh 3.9
Loading the repairs from 0005831 cause the definition and comment method to stop.

Like Pogo says, we have found the enemy and he is us.
 
(0013110 - 221 - 248 - 248 - 248 - 248 - 248)
wiz
05-03-09 03:46

Missed a needed edit in ChangeSorter>setContents.
currentClassName now includes the annotation for packages
it can no longer be directly used as a class name key.

Fixed in ChangeSorter-setContents.st uploaded above.
 
(0013132 - 516 - 552 - 552 - 552 - 552 - 552)
wiz
06-05-09 15:23

Yikes. Found another missed edit.
This time in ChangeSorter>>selectedClassOrMetaClass
this one affects the file out of traits. And probably is responsible for the complaints about file outs not working on the Pharo list.

What I am really wishing for is a good comprehensive suite of file out tests.
Basicly, a smoke test that proves one of everything that can be filed out gets into the file out. Ideally this should be checkable by writing to an internal stream so we are not dealing with disk accesses here.
 
(0013133 - 202 - 238 - 238 - 238 - 238 - 238)
wiz
06-05-09 16:10

Reminder sent to: MarcusDenker, stef

Hi Stef, Hi Marcus,

I read about problems with fileouts being broken in Pharo.
This bug report has found some of the cause.
Both patches will help.

Yours in curiosity and service, --Jerome Peace
 
(0013563 - 441 - 483 - 483 - 483 - 483 - 483)
wiz
03-17-10 07:03

Uploaded CSorter-fix-m7463-wiz.1.cs
which contains the two separate fixes previously uploaded and a updated class comment to warn about the need to filter the ivars used to hold the menu-by-item strings.

Could still use some good comprehensive tests for change sorter. A bit beyond my imagination at the moment.

Anyhow you can load just this one changeset instead of the other fileouts to solve the reports complaint.

Cheers --Jer
 
(0013598 - 23 - 29 - 29 - 138 - 138 - 138)
nicolas cellier
03-29-10 21:38

See 0007463
Jerome, OK ?
 
(0013673 - 397 - 439 - 439 - 548 - 548 - 548)
wiz
04-08-10 19:37

Argh. Hi Nicholas.

The above changes is more current than the one in 0007463. I updated the class comment to warn about the change in ivar usage.
Since a lot of strangers will wander in to fix change sorter the comment becomes important.

The argh is because the version numbers turned out the same. That happens when saving to a different directory than you loaded from. Dang.

Cheers --Jer
 
(0013674 - 419 - 473 - 473 - 473 - 473 - 473)
wiz
04-09-10 00:30

I have done a code browser check of this change set against what is in sq 9885.

AFAICT the needed fixes have NOT gotten in.
So change sets will not do the right thing with traits or indicate class comments.

There seem to be significant changes and conflicts betweent the change set and the current methods so I shall need to look at them again.

Rowr-bazzle :(

Yours in curiosity and service --Jerome Peace
 
(0013678 - 257 - 281 - 281 - 281 - 281 - 281)
wiz
04-09-10 19:24

I have updated my 3.11 image to sq 9926 and compared the current code to this change set. Happy to report that the essential changes now seem to be included. Even the class comment got updated. Good work.

One step closer to release. Yeah.

Cheers --Jer
 

- Issue History
Date Modified Username Field Change
04-28-09 02:04 wiz New Issue
04-28-09 02:04 wiz Status new => assigned
04-28-09 02:04 wiz Assigned To  => KenCausey
04-28-09 02:06 wiz Severity minor => major
04-28-09 02:06 wiz Category Any => Tools
04-28-09 02:15 wiz Assigned To KenCausey =>
05-02-09 21:01 wiz Relationship added related to 0005831
05-02-09 21:01 wiz Relationship added related to 0004825
05-02-09 21:04 wiz Note Added: 0013109
05-03-09 03:41 wiz File Added: ChangeSorter-setContents.st
05-03-09 03:46 wiz Note Added: 0013110
06-05-09 15:23 wiz Note Added: 0013132
06-05-09 15:24 wiz File Added: ChangeSorter-s...OrMetaClass.st
06-05-09 16:10 wiz Issue Monitored: MarcusDenker
06-05-09 16:10 wiz Issue Monitored: stef
06-05-09 16:10 wiz Note Added: 0013133
06-06-09 18:40 wiz Note Added: 0013134
06-06-09 18:41 wiz Note Deleted: 0013134
12-14-09 23:09 wiz Relationship added related to 0007412
02-02-10 03:15 wiz Relationship added related to 0007463
03-09-10 20:11 laza Status assigned => confirmed
03-17-10 06:58 wiz File Added: CSorter-fix-m7463-wiz.1.cs
03-17-10 07:03 wiz Note Added: 0013563
03-18-10 21:47 wiz Relationship added child of 0007480
03-29-10 21:38 nicolas cellier Note Added: 0013598
03-29-10 21:38 nicolas cellier Status confirmed => pending
04-08-10 19:37 wiz Note Added: 0013673
04-09-10 00:30 wiz Note Added: 0013674
04-09-10 19:24 wiz Note Added: 0013678


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
112 total queries executed.
62 unique queries executed.
Powered by Mantis Bugtracker