Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0007351 [Squeak] Kernel minor always 05-11-09 21:30 04-18-10 22:05
Reporter nicolas cellier View Status public  
Assigned To lewis
Priority normal Resolution fixed  
Status closed   Product Version 3.10.2
Summary 0007351: SmalltalkImage image suffix problem not solved by 5851
Description SmalltalkImage current fullNameForImageNamed: 'Squeak3.10.2-7179-basic'.
-> Squeak3.10.image

This method used to automatically ensure .image prefix does it wrong!
It ensures .image prefix but gobble part of the name...
Additional Information Keith introduced a workaround in #saveAs: in 0005851 , but this does not solve all the problems.

correct method is simply:
fullNameForImageNamed: aName
    | imgDir |
    imgDir := FileDirectory on: self imagePath.
    ^FileDirectory fileName: (imgDir fullNameFor: aName) extension: FileDirectory imageSuffix.

A little more tricky:
fullNameForChangesNamed: aName
    | imgName |
    imgName := self fullNameForImageNamed: aName.
    ^FileDirectory fileName: (FileDirectory baseNameFor: imgName) extension: FileDirectory changeSuffix.
Attached Files  M7351-SmallTalkImage-extension-fix-nice.1.cs [^] (782 bytes) 05-11-09 21:35
 M7351-SmallTalkImage-extension-test-nice.1.cs [^] (1,205 bytes) 05-11-09 21:49

- Relationships

- Notes
(0013124 - 143 - 155 - 155 - 155 - 155 - 155)
nicolas cellier
05-11-09 21:36
edited on: 05-11-09 22:26

While at it, I would also recommend imageSuffix and changeSuffix be moved from FileDirectory class to SmalltalkImage or SmalltalkImage class.

 
(0013125 - 197 - 251 - 251 - 251 - 251 - 251)
nicolas cellier
05-11-09 22:25

"fix begin"
Installer mantis bug: 7351 fix: 'M7351-SmallTalkImage-extension-fix-nice.1.cs'.
"fix test"
Installer mantis bug: 7351 fix: 'M7351-SmallTalkImage-extension-test-nice.1.cs'.
"fix end"
 
(0013284 - 59 - 59 - 209 - 209 - 209 - 209)
nicolas cellier
08-24-09 20:26

Fixed in http://source.squeak.org/trunk/System-nice.116.mcz [^]
 
(0013289 - 22 - 22 - 22 - 22 - 22 - 22)
lewis
08-26-09 00:41

Fixed in Squeak trunk.
 

- Issue History
Date Modified Username Field Change
05-11-09 21:30 nicolas cellier New Issue
05-11-09 21:35 nicolas cellier File Added: M7351-SmallTalkImage-extension-fix-nice.1.cs
05-11-09 21:36 nicolas cellier Note Added: 0013124
05-11-09 21:49 nicolas cellier File Added: M7351-SmallTalkImage-extension-test-nice.1.cs
05-11-09 22:25 nicolas cellier Note Added: 0013125
05-11-09 22:26 nicolas cellier Note Edited: 0013124
06-30-09 07:42 nicolas cellier Issue Monitored: nicolas cellier
06-30-09 07:43 nicolas cellier Issue End Monitor: nicolas cellier
08-24-09 20:26 nicolas cellier Note Added: 0013284
08-26-09 00:41 lewis Status new => resolved
08-26-09 00:41 lewis Resolution open => fixed
08-26-09 00:41 lewis Assigned To  => lewis
08-26-09 00:41 lewis Note Added: 0013289
04-18-10 22:05 andreas Status resolved => closed


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
61 total queries executed.
38 unique queries executed.
Powered by Mantis Bugtracker