Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0007356 [Squeak] Kernel minor always 06-26-09 02:46 04-18-10 22:06
Reporter lewis View Status public  
Assigned To lewis
Priority normal Resolution fixed  
Status closed   Product Version 3.10.2
Summary 0007356: DateAndTime fromSeconds: 0.5 => walkback, broken since Mantis 4669
Description Since applying Mantis 4669, DateAndTime class>>fromSeconds: produces an MNU walkback if the argument is not an Integer. Prior to Mantis 4669 the method accepted any Number as argument. The original behavior is used in TimeZoneDatabase package to support time and date conversion.
Additional Information
Attached Files  DateAndTime-fromSeconds-dtl-M7356.cs [^] (2,763 bytes) 06-26-09 02:53

- Relationships
related to 0004669closed  [ENH] TimeForSpeed 

- Notes
(0013136 - 701 - 755 - 755 - 755 - 755 - 755)
lewis
06-26-09 02:51

Patch attached:

Change Set: DateAndTime-fromSeconds-dtl
Date: 25 June 2009
Author: David T. Lewis

Allow #fromSeconds: to accept non-integer arguments, and update Time>>printString to display fractional seconds for better compatibility with the original Squeak implementation. The expressions 'DateAndTime fromSeconds: 0.5' and 'Time fromSeconds: 0.5' now behave as expected.

This change set fixes a limitation of #fromSeconds: that was introduced in Mantis 4669: [ENH] TimeForSpeed. It changes the corresponding #fromSeconds: and #printString for class Time to match DateAndTime and to be more compatible with the original Squeak implementation.
 
(0013161 - 475 - 499 - 499 - 499 - 499 - 499)
gsa
07-08-09 18:24

I tried on a 3.10.2.7179 and seems to work ok.

Before install I run the tests, then installed the .cs, checked that the problem it solves is away and run again the tests.

I noticed that in the second execution i got 2670 tests passed (instead the 2664 of the first time). And, of course, 22 failures instead the 28 of the first time. But as I run all the tests without an exhaustive analysis not sure if is this .cs is the responsible of having now 6 more tests passed.
 
(0013180 - 55 - 55 - 55 - 55 - 55 - 55)
lewis
07-13-09 16:12

Patch applied to source.squeak.org/trunk Kernel-dtl.177
 

- Issue History
Date Modified Username Field Change
06-26-09 02:46 lewis New Issue
06-26-09 02:46 lewis Issue Monitored: lewis
06-26-09 02:48 lewis File Added: DateAndTime-fromSeconds-dtl.3.cs
06-26-09 02:51 lewis Note Added: 0013136
06-26-09 02:53 lewis File Added: DateAndTime-fromSeconds-dtl-M7356.cs
06-26-09 02:53 lewis File Deleted: DateAndTime-fromSeconds-dtl.3.cs
06-26-09 02:54 lewis Relationship added related to 0004669
07-08-09 18:24 gsa Note Added: 0013161
07-13-09 16:12 lewis Status new => resolved
07-13-09 16:12 lewis Resolution open => fixed
07-13-09 16:12 lewis Assigned To  => lewis
07-13-09 16:12 lewis Note Added: 0013180
04-18-10 22:06 andreas Status resolved => closed


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
58 total queries executed.
37 unique queries executed.
Powered by Mantis Bugtracker