0007486: ListChooser doesn't scroll with mouse wheel

(0013603 - 425 - 465 - 465 - 465 - 465 - 465)
rh
03-30-10 10:17

Just to clarify, it happens in situations when the list of existing categories is long and ListChooser is used instead of MenuMorph to render the window (see MorphicUIManager>>chooseFrom:lines:title:)

This also affects other places using ListChooser, like "Find class" etc

It's quite confusing to see two different things pop up for the same action, depending on how many lines they show. ListChooser looks rather ugly.

(0013612 - 61 - 61 - 61 - 61 - 61 - 61)
laza
04-01-10 06:23

I've split the bug report to cover the two problems described

(0013618 - 939 - 1467 - 1467 - 1467 - 1467 - 1467)
FrankShearar
04-03-10 13:13

The problem is in ListChooser>>keyStrokeFromList:.

Scrolling with the mouse send a "keyboard event" of <Ctrl-down>. #keyStrokeFromList: sends that straight to the SearchMorph, so the PluggableListMorphPlus never sees it.

However, changing this method to this:

keyStrokeFromList: event
    "we don't want the list to be picking up events"

    window world primaryHand keyboardFocus: searchMorph.
    "Don't sent ctrl-up/ctrl-down events to the searchMorph: they're scrolling events."
    (#(30 31) contains: [:each | each = event keyValue]) not
        ifTrue:
            [searchMorph keyStroke: event.
            "let the list know we've dealt with it"
            ^true].
    ^false.

doesn't really help. (OK, I hate that #(30 31) business as well.) The above change lets the FIRST up/downscroll through to the underlying list, but then subsequent scroll attempts do nothing. You have to focus on another window and then back to the ListChooser to scroll again.

(0013619 - 536 - 1052 - 1052 - 1052 - 1052 - 1052)
FrankShearar
04-03-10 13:32

Well, of course only the first event works. After that, the searchMorph has focus. This version fixes the situation:

keyStrokeFromList: event
    "we don't want the list to be picking up events, excepting scroll events"

    "Don't sent ctrl-up/ctrl-down events to the searchMorph: they're scrolling events."
    (#(30 31) contains: [:each | each = event keyValue]) not
        ifTrue:
            [window world primaryHand keyboardFocus: searchMorph.
            searchMorph keyStroke: event.
            "let the list know we've dealt with it"
            ^true].
    ^false.

(0013621 - 87 - 87 - 259 - 259 - 259 - 259)
FrankShearar
04-03-10 15:29

Proposed fix committed to http://source.squeak.org/inbox/ToolBuilder-Morphic-fbs.54.mcz [^]

(0013624 - 46 - 46 - 46 - 46 - 46 - 46)
FrankShearar
04-04-10 16:36

ToolBuilder-Morphic-fbs.54, committed to trunk

Issue History
Date Modified	Username	Field	Change
03-30-10 08:48	rh	New Issue
03-30-10 10:17	rh	Note Added: 0013603
04-01-10 05:51	laza	Status	new => confirmed
04-01-10 05:51	laza	Category	Browser => Morphic
04-01-10 05:51	laza	Summary	Add method category window doesn't scroll with mouse wheel => ListChooser doesn't scroll with mouse wheel
04-01-10 05:51	laza	Relationship added	child of 0007480
04-01-10 06:21	laza	Relationship added	related to 0007488
04-01-10 06:23	laza	Note Added: 0013612
04-03-10 13:13	FrankShearar	Note Added: 0013618
04-03-10 13:32	FrankShearar	Note Added: 0013619
04-03-10 14:00	FrankShearar	Status	confirmed => assigned
04-03-10 14:00	FrankShearar	Assigned To	=> FrankShearar
04-03-10 15:29	FrankShearar	Note Added: 0013621
04-03-10 18:25	FrankShearar	Status	assigned => feedback
04-04-10 16:36	FrankShearar	Status	feedback => resolved
04-04-10 16:36	FrankShearar	Resolution	open => fixed
04-04-10 16:36	FrankShearar	Note Added: 0013624
04-18-10 21:54	andreas	Status	resolved => closed

Notes
(0013603 - 425 - 465 - 465 - 465 - 465 - 465) rh 03-30-10 10:17	Just to clarify, it happens in situations when the list of existing categories is long and ListChooser is used instead of MenuMorph to render the window (see MorphicUIManager>>chooseFrom:lines:title:) This also affects other places using ListChooser, like "Find class" etc It's quite confusing to see two different things pop up for the same action, depending on how many lines they show. ListChooser looks rather ugly.

(0013612 - 61 - 61 - 61 - 61 - 61 - 61) laza 04-01-10 06:23	I've split the bug report to cover the two problems described

(0013618 - 939 - 1467 - 1467 - 1467 - 1467 - 1467) FrankShearar 04-03-10 13:13	The problem is in ListChooser>>keyStrokeFromList:. Scrolling with the mouse send a "keyboard event" of <Ctrl-down>. #keyStrokeFromList: sends that straight to the SearchMorph, so the PluggableListMorphPlus never sees it. However, changing this method to this: keyStrokeFromList: event "we don't want the list to be picking up events" window world primaryHand keyboardFocus: searchMorph. "Don't sent ctrl-up/ctrl-down events to the searchMorph: they're scrolling events." (#(30 31) contains: [:each \| each = event keyValue]) not ifTrue: [searchMorph keyStroke: event. "let the list know we've dealt with it" ^true]. ^false. doesn't really help. (OK, I hate that #(30 31) business as well.) The above change lets the FIRST up/downscroll through to the underlying list, but then subsequent scroll attempts do nothing. You have to focus on another window and then back to the ListChooser to scroll again.

(0013619 - 536 - 1052 - 1052 - 1052 - 1052 - 1052) FrankShearar 04-03-10 13:32	Well, of course only the first event works. After that, the searchMorph has focus. This version fixes the situation: keyStrokeFromList: event "we don't want the list to be picking up events, excepting scroll events" "Don't sent ctrl-up/ctrl-down events to the searchMorph: they're scrolling events." (#(30 31) contains: [:each \| each = event keyValue]) not ifTrue: [window world primaryHand keyboardFocus: searchMorph. searchMorph keyStroke: event. "let the list know we've dealt with it" ^true]. ^false.

(0013621 - 87 - 87 - 259 - 259 - 259 - 259) FrankShearar 04-03-10 15:29	Proposed fix committed to http://source.squeak.org/inbox/ToolBuilder-Morphic-fbs.54.mcz [^]

(0013624 - 46 - 46 - 46 - 46 - 46 - 46) FrankShearar 04-04-10 16:36	ToolBuilder-Morphic-fbs.54, committed to trunk