Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0007719 [Squeak] Tools minor always 01-17-13 14:11 01-21-13 10:37
Reporter Bob Arning View Status public  
Assigned To lewis
Priority normal Resolution fixed  
Status resolved   Product Version 4.4
Summary 0007719: FileContentsBrowser erroneously adds to current change set
Description I'm not sure how many folks still use FileContentsBrowser, but there is a small issue:

browseStream: aStream named: aString

    | browser |
    Cursor wait showWhile: [ | package packageDict organizer |
        packageDict := Dictionary new.
        browser := self new.
        organizer := SystemOrganizer defaultList: Array new.
        package := (FilePackage new fullName: aString; fileInFrom: aStream).
        packageDict
            at: package packageName
            put: package.
        organizer
            classifyAll: package classes keys
            under: package packageName.
        (browser := self systemOrganizer: organizer)
            packages: packageDict].
    self
        openBrowserView: browser createViews
        label: 'File Contents Browser'.

which soon leads to SystemOrganizer

classify: element under: newCategory
    | oldCategory class |
    oldCategory := self categoryOfElement: element.
    super classify: element under: newCategory.
    class := Smalltalk at: element ifAbsent: [^ self].
    SystemChangeNotifier uniqueInstance
        class: class
        recategorizedFrom: oldCategory
        to: newCategory

which causes all known classes in the file being browsed to be added to the current change set as having a class definition change. Perhaps it makes sense to do the notification only if this SystemOrganizer is actually SystemOrganization.
Additional Information
Attached Files

- Relationships

- Notes
(0014292 - 68 - 68 - 216 - 216 - 216 - 216)
FrankShearar
01-20-13 15:15

http://source.squeak.org/inbox/System-dtl.512.mcz [^] is a proposed fix.
 
(0014295 - 19 - 19 - 19 - 19 - 19 - 19)
FrankShearar
01-21-13 10:37

Fix moved to trunk.
 

- Issue History
Date Modified Username Field Change
01-17-13 14:11 Bob Arning New Issue
01-20-13 15:15 FrankShearar Note Added: 0014292
01-20-13 15:16 FrankShearar Assigned To  => lewis
01-20-13 15:16 FrankShearar Status new => testing
01-21-13 10:37 FrankShearar Status testing => resolved
01-21-13 10:37 FrankShearar Resolution open => fixed
01-21-13 10:37 FrankShearar Note Added: 0014295


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
41 total queries executed.
33 unique queries executed.
Powered by Mantis Bugtracker