Mantis Bugtracker
  

Viewing Issue Simple Details Jump to Notes ] View Advanced ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0007807 [Squeak] Morphic minor always 01-08-14 18:26 01-14-14 00:31
Reporter tim View Status public  
Assigned To
Priority normal Resolution open  
Status new   Product Version 4.4
Summary 0007807: Morphic drag/drop methods with confusing code and comments
Description After digging around a large number of drag/drop related methods I have
a) a rather better understanding of how it works
b) a small list of rather odd methods that seem in need of a moments consideration and probably improving.

There seems to be some confusion about the meaning and use of #isPartsBin[:] & #isPartsDonor[:], a rather confused PasteUpMorph>repelsMorph:event: (and #wantsDroppedMorph:event:), and the usual confused and/or outdated comments that mislead the reader.
Additional Information The attached change set is a bunch of methods where I have simply commented what I suspect to be wrong or in need of improving. Just before a release is not a time to change a basic bit of code in PasteUpMorph without review.
Attached Files  DragDropQuestions.1.cs [^] (4,509 bytes) 01-08-14 18:26

- Relationships

- Notes
(0014486 - 275 - 329 - 329 - 329 - 329 - 329)
tim
01-14-14 00:31

A couple of extra uglinesses from Karl Ramberg-

A few comments:
CompoundTileMorph contain other morphs that wants drops, so I don't think you can reject drops to it.

Morph>>mouseDownPriority shows some of the confusion with isPartsBin and isPartsDonor

Cheers,
Karl
 

- Issue History
Date Modified Username Field Change
01-08-14 18:26 tim New Issue
01-08-14 18:26 tim File Added: DragDropQuestions.1.cs
01-14-14 00:31 tim Note Added: 0014486


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
33 total queries executed.
26 unique queries executed.
Powered by Mantis Bugtracker