Mantis Bugtracker
  

Viewing Issue Advanced Details Jump to Notes ] View Simple ] Issue History ] Print ]
ID Category Severity Reproducibility Date Submitted Last Update
0000985 [Squeak 5.2] feature N/A 03-16-05 01:04 04-06-05 10:30
Reporter ohshima View Status public  
Assigned To
Priority normal Resolution open Platform
Status new   OS
Projection none   OS Version
ETA none Product Build
Summary 0000985: Stop adding halos for some special objects.
Description For example,if the navigator is deleted from the X button, there is not an easy way to get it back. If Preferences eToyFriendly is true, this patch prohibits halos for particular objects.
Steps To Reproduce
Additional Information
Attached Files  NoHaloObjects.cs [^] (3,786 bytes) 03-16-05 01:05
 NoHaloEtoysFlap.cs.gz [^] (1,354 bytes) 04-05-05 07:15
 noHaloForEToyFlap-sw.2.cs.gz [^] (434 bytes) 04-06-05 09:47

- Relationships

- Notes
(0001269 - 41 - 41 - 41 - 41 - 41 - 41)
tak
03-16-05 06:32

Added to Nihongo7 as 0046NoHaloObjects.cs
 
(0001321 - 273 - 273 - 273 - 273 - 273 - 273)
ScottWallace
03-30-05 15:11

One problem I noticed with this is that is makes it impossible to get a halo on a FlapTab. Unfortunately, it's in its halo menu that all of the controls that govery a Flap reside, so it's essential that it be possible to get a halo on the tab. Even in eToyFriendly mode.
 
(0001322 - 83 - 83 - 83 - 83 - 83 - 83)
ohshima
03-30-05 17:36

Probably disabling it for the Navigator and Supplies but not others may make sense.
 
(0001345 - 84 - 84 - 84 - 84 - 84 - 84)
tak
04-05-05 07:19

This file (NoHaloEtoysFlap.cs) is to show flap's halo except Navigator and Supplies.
 
(0001347 - 909 - 951 - 951 - 951 - 951 - 951)
ScottWallace
04-06-05 09:51

OUCH! I installed the new "NoHaloEtoysFlap" (from Yamamiya-san, dated 5 April,) and set eToyFriendly to true, and I found that although it's true that a right-click on the Supplies and Navigator flap-tabs would no longer bring up a halo on them, the bad news is that doing a right-click on either of those flap-tabs results in an actual VM hang or crash, *every time*! It appears that it is *not good* ever to return nil from #addHalo: -- this seemingly needs always to return a HaloMorph object. (This didn't cause a crash in Yoshiki's original "NoHaloObjects" fileout of 16 March, but that's because Yoshiki's fileout had modified Morph.blueButtonDown to make it able to contend with a nil return from addHalo:).

I'm uploading an alternative proposal, "noHaloForEToyFlap-sw.2", which purports to solve the immediate desiderata of this thread in a different but simple way. Let me know what you think.
 
(0001351 - 359 - 383 - 383 - 383 - 383 - 383)
tak
04-06-05 10:30

Oops,

Actually, you need to install Yoshiki's NoHaloObjects.cs before NoHaloEtoysFlap.cs.gz (My explain was too short ...). Yoshiki's change set fixes more than Flap - Menu, Paintbox, Viewer, or so. I think this is good for novice user to avoid unexpected operation.

I agree #wantsHaloFromClick is absolutely better place to control halo than #addHalo:.
 

- Issue History
Date Modified Username Field Change
03-16-05 01:04 ohshima New Issue
03-16-05 01:05 ohshima File Added: NoHaloObjects.cs
03-16-05 06:32 tak Note Added: 0001269
03-30-05 15:11 ScottWallace Note Added: 0001321
03-30-05 17:36 ohshima Note Added: 0001322
04-05-05 07:15 tak File Added: NoHaloEtoysFlap.cs.gz
04-05-05 07:19 tak Note Added: 0001345
04-06-05 09:47 ScottWallace File Added: noHaloForEToyFlap-sw.2.cs.gz
04-06-05 09:51 ScottWallace Note Added: 0001347
04-06-05 10:30 tak Note Added: 0001351


Mantis 1.0.8[^]
Copyright © 2000 - 2007 Mantis Group
59 total queries executed.
38 unique queries executed.
Powered by Mantis Bugtracker