Mantis - Squeak
Viewing Issue Advanced Details
1523 Network minor always 07-22-05 18:46 04-18-07 11:35
mzimmerm  
 
normal  
new  
open  
none    
none  
0001523: [FIX] FTPBinaryModeFix-nk
ned@squeakland.org:

"from preamble:

"Change Set: FTPBinaryModeFix-nk
Date: 26 January 2005
Author: Ned Konz

Between opening files as MultiByteFileStreams and not setting the FTP
servers into binary mode, we weren't getting reliable transfers of
binary data.

This change set ensures that the same bytes end up on both sides of the
wire.
"!"
child of 0001526new  [ENH] FTPDragNDrop-nk 
 FTPBinaryModeFix-nk.cs.gz [^] (1,168 bytes) 07-22-05 18:46

Notes
(0001872)
mzimmerm   
07-22-05 18:56   
frank.shearar@rnid.org.uk:

"The changes are simple.

One thing that would be really nice is a suite of tests. This would
either require a mockup of the network or a working FTP server in the
image. (A remote FTP server as a fixture in a test suite is a Bad Idea.)

frank"
(0001873)
mzimmerm   
07-22-05 18:59   
Michael Rueger <michael@squeakland.org>:

"But what if you want ascii transfer? This change set forces binary mode
in all kinds of places (e.g. getFileNamed:) that are not necessarily
meant to be binary IMO."

Michael"
(0001874)
mzimmerm   
07-22-05 19:00   
Ned Konz <ned@squeakland.org>:

"Is character translation properly the job of a file transfer protocol?

My feeling is that it isn't; that it is a service that should be provided by a
higher layer. If a particular *use* of a transferred file requires
translating line endings, then that use is welcome to provide that service.

--
Ned Konz"
(0001875)
mzimmerm   
07-22-05 19:01   
When moving this item from BFAV to mantis I verified the changeset installs in 3.8-6665 final, but did not perform any further testing.
(0010576)
edgardec   
04-18-07 11:35   
Reminder sent to: gokr


I wish harvest as many code here as possible for 3.10
Goran what you have to say ?
It's this good ?