Mantis - Squeak
Viewing Issue Advanced Details
1554 Kernel minor always 07-26-05 19:39 07-28-13 14:57
KenCausey  
 
normal  
resolved trunk  
fixed  
none    
none  
0001554: [FIX] ClassVarsFix-petervr-v2 for compiler class var & global var shadowing issue
from preamble:

"Change Set: ClassVarsFix-petervr-v2
Date: 9 October 2003
Author: Peter van Rooijen

fixes the lookup of class variables.
previously, inherited class variables
did not shadow other shared variables.

v2 - minor improvements"!
related to 0005905resolved nicolas cellier please let class vars shadow globals 
 ClassVarsFix-petervr-v2.cs.gz [^] (1,145 bytes) 07-26-05 19:39
 Tests-ClassVarsFix.st.gz [^] (1,022 bytes) 07-26-05 19:43

Notes
(0001971)
KenCausey   
07-26-05 19:41   
"Peter van Rooijen" <squeak@vanrooijen.com>:

"I added some SUnit tests to demonstrate the bug and give credibility to the
fix.

Only two of the tests fail in an unfixed image. The rest serve as regression
tests.

All the tests pass after the fix is installed.

I added the tests as a file-out. I tried filing it into a change set, but
doing that lost the class comment."

(attaching Tests-ClassVarsFix.st.gz)
(0001972)
KenCausey   
07-26-05 19:44   
marcus@ira.uka.de:

"See the discussion:

http://lists.squeakfoundation.org/pipermail/squeak-dev/2003-October/068300.html [^]
"
(0001973)
KenCausey   
07-26-05 19:47   
I filed in the test into a 3.8-6665-basic image and 2 out of the 10 tests failed. I then filed in the fix changeset and ran the tests again and all 10 passed.
(0014425)
nicolas cellier   
07-28-13 14:54   
The tests have been loaded in Squeak4.5 Trunk http://source.squeak.org/trunk/KernelTests-nice.253.mcz [^]
The lookup workaround has been loaded in Trunk http://source.squeak.org/trunk/Kernel-nice.797.mcz [^]